sensu-plugins/sensu-plugins-elasticsearch

View on GitHub
bin/metrics-es-node-graphite.rb

Summary

Maintainability
D
1 day
Test Coverage

Method run has a Cognitive Complexity of 54 (exceeds 5 allowed). Consider refactoring.
Open

  def run
    # invert various stats depending on if some flags are set
    os_stat = !config[:disable_os_stats]
    process_stats = !config[:disable_process_stats]
    jvm_stats = !config[:disable_jvm_stats]
Severity: Minor
Found in bin/metrics-es-node-graphite.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has 133 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run
    # invert various stats depending on if some flags are set
    os_stat = !config[:disable_os_stats]
    process_stats = !config[:disable_process_stats]
    jvm_stats = !config[:disable_jvm_stats]
Severity: Major
Found in bin/metrics-es-node-graphite.rb - About 5 hrs to fix

    Method get_es_resource has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

      def get_es_resource(resource)
        headers = {}
        if config[:user] && config[:password]
          auth = 'Basic ' + Base64.strict_encode64("#{config[:user]}:#{config[:password]}").chomp
          headers = { 'Authorization' => auth }
    Severity: Minor
    Found in bin/metrics-es-node-graphite.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status