sensu-plugins/sensu-plugins-etcd

View on GitHub

Showing 11 of 11 total issues

Method run has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

  def run
    if config[:allmembers]
      members = JSON.parse(request('/v2/members', config[:server]).to_str)['members']
      bad_peers = []
      members.each do |member|
Severity: Minor
Found in bin/check-etcd.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

  def run
    protocol = config[:ssl] ? 'https' : 'http'
    r = RestClient::Resource.new("#{protocol}://#{config[:server]}:#{config[:port]}/v2/members",
                                 timeout: 5,
                                 ssl_client_cert: (OpenSSL::X509::Certificate.new(File.read(config[:cert])) unless config[:cert].nil?),
Severity: Minor
Found in bin/check-etcd-peer-count.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  def request(path, server)
    protocol = config[:ssl] ? 'https' : 'http'
    RestClient::Resource.new("#{protocol}://#{server}:#{config[:port]}/#{path}",
                             timeout: 5,
                             ssl_client_cert: (OpenSSL::X509::Certificate.new(File.read(config[:cert])) unless config[:cert].nil?),
Severity: Major
Found in bin/check-etcd.rb and 1 other location - About 1 hr to fix
bin/check-flannel-subnet-count.rb on lines 119..128

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 73.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  def request(path, server)
    protocol = config[:ssl] ? 'https' : 'http'
    RestClient::Resource.new(
      "#{protocol}://#{server}:#{config[:port]}/#{path}",
      timeout: 5,
Severity: Major
Found in bin/check-flannel-subnet-count.rb and 1 other location - About 1 hr to fix
bin/check-etcd.rb on lines 122..129

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 73.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method run has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

  def run
    if config[:ssl]
      client = Etcd.client(
        host: config[:etcd_host],
        port: config[:etcd_port],
Severity: Minor
Found in bin/metrics-etcd.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run
    if config[:allmembers]
      members = JSON.parse(request('/v2/members', config[:server]).to_str)['members']
      bad_peers = []
      members.each do |member|
Severity: Minor
Found in bin/check-etcd.rb - About 1 hr to fix

    Method run has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def run
        if config[:ssl]
          client = Etcd.client(
            host: config[:etcd_host],
            port: config[:etcd_port],
    Severity: Minor
    Found in bin/metrics-etcd.rb - About 1 hr to fix

      Method run has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def run
          begin # Get the network configuration
            flannel_config = request('v2/keys/coreos.com/network/config', config[:server])
            # The value is stored as a json string within the json, so we have to parse, pull out the string and re-parse...
            num_address = JSON.parse(JSON.parse(flannel_config.to_str)['node']['value'])['Network']
      Severity: Minor
      Found in bin/check-flannel-subnet-count.rb - About 1 hr to fix

        Method request has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

          def request(path, server)
            protocol = config[:ssl] ? 'https' : 'http'
            RestClient::Resource.new("#{protocol}://#{server}:#{config[:port]}/#{path}",
                                     timeout: 5,
                                     ssl_client_cert: (OpenSSL::X509::Certificate.new(File.read(config[:cert])) unless config[:cert].nil?),
        Severity: Minor
        Found in bin/check-etcd.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method request has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

          def request(path, server)
            protocol = config[:ssl] ? 'https' : 'http'
            RestClient::Resource.new(
              "#{protocol}://#{server}:#{config[:port]}/#{path}",
              timeout: 5,
        Severity: Minor
        Found in bin/check-flannel-subnet-count.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method run has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          def run
            begin # Get the network configuration
              flannel_config = request('v2/keys/coreos.com/network/config', config[:server])
              # The value is stored as a json string within the json, so we have to parse, pull out the string and re-parse...
              num_address = JSON.parse(JSON.parse(flannel_config.to_str)['node']['value'])['Network']
        Severity: Minor
        Found in bin/check-flannel-subnet-count.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language