sensu-plugins/sensu-plugins-graphite

View on GitHub

Showing 33 of 33 total issues

File check-graphite.rb has 444 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'sensu-plugin/check/cli'
require 'json'
require 'net/http'
require 'net/https'
require 'socket'
Severity: Minor
Found in bin/check-graphite.rb - About 6 hrs to fix

    Method check_average_percent has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
    Open

      def check_average_percent(target, max_values, data_points = 1)
        values = get_graphite_values target
        last_values = last_graphite_value(target, data_points)
        return [[], [], []] unless values
        warnings = []
    Severity: Minor
    Found in bin/check-graphite.rb - About 6 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method run has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
    Open

      def run # rubocop:disable AbcSize
        targets = config[:complex_target] ? [config[:target]] : config[:target].split(',')
        @period = config[:period]
        critical_errors = []
        warnings = []
    Severity: Minor
    Found in bin/check-graphite.rb - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method check_last has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
    Open

      def check_last(target, max_values)
        last_targets = last_graphite_value target
        return [[], [], []] unless last_targets
        warnings = []
        criticals = []
    Severity: Minor
    Found in bin/check-graphite.rb - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method check_percentile has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
    Open

      def check_percentile(target, max_values, percentile, data_points = 1)
        values = get_graphite_values target
        last_values = last_graphite_value(target, data_points)
        return [[], [], []] unless values
        warnings = []
    Severity: Minor
    Found in bin/check-graphite.rb - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method check_average has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
    Open

      def check_average(target, max_values)
        values = get_graphite_values target
        return [[], [], []] unless values
        warnings = []
        criticals = []
    Severity: Minor
    Found in bin/check-graphite.rb - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method default_options has 87 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def self.default_options
            {
              target: {
                description: 'Graphite data target',
                short: '-t TARGET',
    Severity: Major
    Found in lib/sensu-plugins-graphite/graphite_proxy/options.rb - About 3 hrs to fix

      Method run has 57 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def run # rubocop:disable AbcSize
          targets = config[:complex_target] ? [config[:target]] : config[:target].split(',')
          @period = config[:period]
          critical_errors = []
          warnings = []
      Severity: Major
      Found in bin/check-graphite.rb - About 2 hrs to fix

        Method danger has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

          def danger(metric)
            datapoints = metric['datapoints'].map(&:first).compact
        
            # #YELLOW
            unless datapoints.empty? # rubocop:disable UnlessElse
        Severity: Minor
        Found in bin/check-graphite-stats.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method get_last_metric has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

          def get_last_metric(values, count = 1)
            if values
              ret = []
              values_size = values.size
              count = values_size if count > values_size
        Severity: Minor
        Found in bin/check-graphite.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method check_increasing has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

          def check_increasing(target)
            updated_since = config[:updated_since].to_i
            time_to_be_updated_since = Time.now - updated_since
            critical_errors = []
            warnings = []
        Severity: Minor
        Found in bin/check-graphite.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method run has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

          def run
            body =
              begin
                uri = URI.parse(URI.encode("http://#{config[:host]}/render?format=json&target=#{config[:target]}&from=#{config[:period]}"))
                res = Net::HTTP.get_response(uri)
        Severity: Minor
        Found in bin/check-graphite-stats.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method check_percentile has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def check_percentile(target, max_values, percentile, data_points = 1)
            values = get_graphite_values target
            last_values = last_graphite_value(target, data_points)
            return [[], [], []] unless values
            warnings = []
        Severity: Minor
        Found in bin/check-graphite.rb - About 1 hr to fix

          Method check_average_percent has 35 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def check_average_percent(target, max_values, data_points = 1)
              values = get_graphite_values target
              last_values = last_graphite_value(target, data_points)
              return [[], [], []] unless values
              warnings = []
          Severity: Minor
          Found in bin/check-graphite.rb - About 1 hr to fix

            Method check_average has 32 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def check_average(target, max_values)
                values = get_graphite_values target
                return [[], [], []] unless values
                warnings = []
                criticals = []
            Severity: Minor
            Found in bin/check-graphite.rb - About 1 hr to fix

              Method run has 30 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                def run
                  body =
                    begin
                      uri = URI.parse(URI.encode("http://#{config[:host]}/render?format=json&target=#{config[:target]}&from=#{config[:period]}"))
                      res = Net::HTTP.get_response(uri)
              Severity: Minor
              Found in bin/check-graphite-stats.rb - About 1 hr to fix

                Method check_last has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  def check_last(target, max_values)
                    last_targets = last_graphite_value target
                    return [[], [], []] unless last_targets
                    warnings = []
                    criticals = []
                Severity: Minor
                Found in bin/check-graphite.rb - About 1 hr to fix

                  Method run has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    def run
                      messages = []
                      servers = config[:servers].split(',')
                      relay_ips = find_relay_ips(config[:relays].split(','))
                  
                  
                  Severity: Minor
                  Found in bin/check-graphite-replication.rb - About 1 hr to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            if !config[:crit].nil? && avg < config[:crit] # rubocop:disable Style/IfInsideElse
                              return [2, "#{metric['target']} is #{avg}"]
                            elsif !config[:warn].nil? && avg < config[:warn]
                              return [1, "#{metric['target']} is #{avg}"]
                            end
                    Severity: Minor
                    Found in bin/check-graphite-stats.rb and 1 other location - About 55 mins to fix
                    bin/check-graphite-stats.rb on lines 103..107

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 46.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            if !config[:crit].nil? && avg > config[:crit]
                              return [2, "#{metric['target']} is #{avg}"]
                            elsif !config[:warn].nil? && avg > config[:warn]
                              return [1, "#{metric['target']} is #{avg}"]
                            end
                    Severity: Minor
                    Found in bin/check-graphite-stats.rb and 1 other location - About 55 mins to fix
                    bin/check-graphite-stats.rb on lines 109..113

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 46.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Severity
                    Category
                    Status
                    Source
                    Language