Sign upLogin

sensu-plugins/sensu-plugins-graphite

View on GitHub
Star

Showing 23 of 33 total issues

File check-graphite.rb has 444 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'sensu-plugin/check/cli'
require 'json'
require 'net/http'
require 'net/https'
require 'socket'
Severity: Minor
Found in bin/check-graphite.rb - About 6 hrs to fix

    Method check_average_percent has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
    Open

      def check_average_percent(target, max_values, data_points = 1)
    values = get_graphite_values target
    last_values = last_graphite_value(target, data_points)
    return [[], [], []] unless values
    warnings = []
    Severity: Minor
    Found in bin/check-graphite.rb - About 6 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method run has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
    Open

      def run # rubocop:disable AbcSize
    targets = config[:complex_target] ? [config[:target]] : config[:target].split(',')
    @period = config[:period]
    critical_errors = []
    warnings = []
    Severity: Minor
    Found in bin/check-graphite.rb - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method check_percentile has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
    Open

      def check_percentile(target, max_values, percentile, data_points = 1)
    values = get_graphite_values target
    last_values = last_graphite_value(target, data_points)
    return [[], [], []] unless values
    warnings = []
    Severity: Minor
    Found in bin/check-graphite.rb - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method check_last has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
    Open

      def check_last(target, max_values)
    last_targets = last_graphite_value target
    return [[], [], []] unless last_targets
    warnings = []
    criticals = []
    Severity: Minor
    Found in bin/check-graphite.rb - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method check_average has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
    Open

      def check_average(target, max_values)
    values = get_graphite_values target
    return [[], [], []] unless values
    warnings = []
    criticals = []
    Severity: Minor
    Found in bin/check-graphite.rb - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method default_options has 87 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def self.default_options
        {
          target: {
            description: 'Graphite data target',
            short: '-t TARGET',
    Severity: Major
    Found in lib/sensu-plugins-graphite/graphite_proxy/options.rb - About 3 hrs to fix

      Method run has 57 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def run # rubocop:disable AbcSize
    targets = config[:complex_target] ? [config[:target]] : config[:target].split(',')
    @period = config[:period]
    critical_errors = []
    warnings = []
      Severity: Major
      Found in bin/check-graphite.rb - About 2 hrs to fix

        Method danger has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

          def danger(metric)
    datapoints = metric['datapoints'].map(&:first).compact

    # #YELLOW
    unless datapoints.empty? # rubocop:disable UnlessElse
        Severity: Minor
        Found in bin/check-graphite-stats.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method get_last_metric has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

          def get_last_metric(values, count = 1)
    if values
      ret = []
      values_size = values.size
      count = values_size if count > values_size
        Severity: Minor
        Found in bin/check-graphite.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method check_increasing has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

          def check_increasing(target)
    updated_since = config[:updated_since].to_i
    time_to_be_updated_since = Time.now - updated_since
    critical_errors = []
    warnings = []
        Severity: Minor
        Found in bin/check-graphite.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method run has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

          def run
    body =
      begin
        uri = URI.parse(URI.encode("http://#{config[:host]}/render?format=json&target=#{config[:target]}&from=#{config[:period]}"))
        res = Net::HTTP.get_response(uri)
        Severity: Minor
        Found in bin/check-graphite-stats.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method check_percentile has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def check_percentile(target, max_values, percentile, data_points = 1)
    values = get_graphite_values target
    last_values = last_graphite_value(target, data_points)
    return [[], [], []] unless values
    warnings = []
        Severity: Minor
        Found in bin/check-graphite.rb - About 1 hr to fix

          Method check_average_percent has 35 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def check_average_percent(target, max_values, data_points = 1)
    values = get_graphite_values target
    last_values = last_graphite_value(target, data_points)
    return [[], [], []] unless values
    warnings = []
          Severity: Minor
          Found in bin/check-graphite.rb - About 1 hr to fix

            Method check_average has 32 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def check_average(target, max_values)
    values = get_graphite_values target
    return [[], [], []] unless values
    warnings = []
    criticals = []
            Severity: Minor
            Found in bin/check-graphite.rb - About 1 hr to fix

              Method check_last has 30 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                def check_last(target, max_values)
    last_targets = last_graphite_value target
    return [[], [], []] unless last_targets
    warnings = []
    criticals = []
              Severity: Minor
              Found in bin/check-graphite.rb - About 1 hr to fix

                Method run has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  def run
    body =
      begin
        uri = URI.parse(URI.encode("http://#{config[:host]}/render?format=json&target=#{config[:target]}&from=#{config[:period]}"))
        res = Net::HTTP.get_response(uri)
                Severity: Minor
                Found in bin/check-graphite-stats.rb - About 1 hr to fix

                  Method run has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    def run
    messages = []
    servers = config[:servers].split(',')
    relay_ips = find_relay_ips(config[:relays].split(','))
                  Severity: Minor
                  Found in bin/check-graphite-replication.rb - About 1 hr to fix

                    Method been_updated_since has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                    Open

                      def been_updated_since(target, time, updated_since)
    last_time_stamp = last_graphite_metric target
    warnings = []
    if last_time_stamp
      last_time_stamp.each do |target_name, value|
                    Severity: Minor
                    Found in bin/check-graphite.rb - About 55 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method run has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                    Open

                      def run
    messages = []
    servers = config[:servers].split(',')
    relay_ips = find_relay_ips(config[:relays].split(','))
                    Severity: Minor
                    Found in bin/check-graphite-replication.rb - About 35 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language