Sign upLogin

sensu-plugins/sensu-plugins-graylog

View on GitHub
Star

Showing 5 of 5 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

Severity: Major
Found in bin/metrics-graylog.py and 1 other location - About 2 hrs to fix
bin/check-graylog-buffers.py on lines 0..9

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

Severity: Major
Found in bin/check-graylog-buffers.py and 1 other location - About 2 hrs to fix
bin/metrics-graylog.py on lines 0..9

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method check_210_buffers has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def check_210_buffers
    postdata = {
      'metrics' => [
        'org.graylog2.buffers.input.usage',
        'org.graylog2.buffers.input.size',
Severity: Minor
Found in bin/check-graylog-buffers.rb - About 1 hr to fix

    Method vhost_alive? has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def vhost_alive?
    protocol = config[:protocol]
    host     = config[:host]
    port     = config[:port]
    username = config[:username]
    Severity: Minor
    Found in bin/check-graylog2-alive.rb - About 1 hr to fix

      Method check_210_buffers has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def check_210_buffers
    postdata = {
      'metrics' => [
        'org.graylog2.buffers.input.usage',
        'org.graylog2.buffers.input.size',
      Severity: Minor
      Found in bin/check-graylog-buffers.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language