sensu-plugins/sensu-plugins-hardware

View on GitHub

Showing 2 of 2 total issues

Method run has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

  def run
    # Validate options
    unknown incompatible_options if incompatible_options

    # Build the command based on the options provided
Severity: Minor
Found in bin/check-hardware-fail.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method incompatible_options has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

  def incompatible_options
    if OS.linux?
      if incompatible_linux.any?
        "The use of the options --seconds and [--#{incompatible_linux.join(' --')}] is incompatible."
      elsif invalid_facility.any?
Severity: Minor
Found in bin/check-hardware-fail.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language