sensu-plugins/sensu-plugins-mailer

View on GitHub

Showing 11 of 11 total issues

Method build_mail_to_list has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

  def build_mail_to_list
    mail_to = Set.new
    mail_to.add(@event['client']['mail_to'] || json_config_settings['mail_to'])
    if json_config_settings.key?('subscriptions') && @event['check']['subscribers']
      @event['check']['subscribers'].each do |sub|
Severity: Minor
Found in bin/handler-mailer.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method handle has 59 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def handle
    body = build_body
    subject = "#{prefix_subject}#{build_subject}"

    content_type = parse_content_type
Severity: Major
Found in bin/handler-mailer.rb - About 2 hrs to fix

    Method handle has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def handle
        params = {
          mail_to: settings[json_config]['mail_to'],
          mail_from: settings[json_config]['mail_from'],
          aws_access_key: settings[json_config]['aws_access_key'],
    Severity: Minor
    Found in bin/handler-mailer-ses.rb - About 1 hr to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          body = <<-BODY.gsub(/^ {14}/, '')
                  #{@event['check']['output']}
                  Host: #{@event['client']['name']}
                  Timestamp: #{Time.at(@event['check']['issued'])}
                  Address:  #{@event['client']['address']}
      Severity: Major
      Found in bin/handler-mailer-ses.rb and 1 other location - About 1 hr to fix
      bin/handler-mailer-mailgun.rb on lines 64..73

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 61.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          body = <<-BODY.gsub(/^ {14}/, '')
                  #{@event['check']['output']}
                  Host: #{@event['client']['name']}
                  Timestamp: #{Time.at(@event['check']['issued'])}
                  Address:  #{@event['client']['address']}
      Severity: Major
      Found in bin/handler-mailer-mailgun.rb and 1 other location - About 1 hr to fix
      bin/handler-mailer-ses.rb on lines 48..57

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 61.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method handle has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def handle
          params = {
            mail_to: settings[json_config]['mail_to'],
            mail_from: settings[json_config]['mail_from'],
            mg_apikey: settings[json_config]['mg_apikey'],
      Severity: Minor
      Found in bin/handler-mailer-mailgun.rb - About 1 hr to fix

        Method build_mail_to_list has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def build_mail_to_list
            mail_to = Set.new
            mail_to.add(@event['client']['mail_to'] || json_config_settings['mail_to'])
            if json_config_settings.key?('subscriptions') && @event['check']['subscribers']
              @event['check']['subscribers'].each do |sub|
        Severity: Minor
        Found in bin/handler-mailer.rb - About 1 hr to fix

          Method handle has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

            def handle
              body = build_body
              subject = "#{prefix_subject}#{build_subject}"
          
              content_type = parse_content_type
          Severity: Minor
          Found in bin/handler-mailer.rb - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            def message_template
              return config[:template] if config[:template]
              return @event['check']['template'] if @event['check']['template']
              return json_config_settings['template'] if json_config_settings['template']
              nil
          Severity: Minor
          Found in bin/handler-mailer.rb and 1 other location - About 25 mins to fix
          bin/handler-mailer.rb on lines 185..189

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 31.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            def subject_template
              return config[:subject_template] if config[:subject_template]
              return @event['check']['subject_template'] if @event['check']['subject_template']
              return json_config_settings['subject_template'] if json_config_settings['subject_template']
              nil
          Severity: Minor
          Found in bin/handler-mailer.rb and 1 other location - About 25 mins to fix
          bin/handler-mailer.rb on lines 205..209

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 31.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method parse_content_type has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            def parse_content_type
              use = if config[:content_type]
                      config[:content_type]
                    elsif @event['check']['content_type']
                      @event['check']['content_type']
          Severity: Minor
          Found in bin/handler-mailer.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language