Sign upLogin

sensu-plugins/sensu-plugins-mailgun

View on GitHub
Star

Showing 8 of 8 total issues

Method gettotal_sen has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

  def gettotal_sen(domains, mailgun_key, events, tags, start_date)
    sent = domains.map do |domain|
      begin
        start_date_string = !start_date.nil? ? "&#{start_date}" : ''
        uri = URI("https://api.mailgun.net/v3/#{domain}/stats?#{events.map { |e| "event=#{e}" }.join('&')}&limit=1#{start_date_string}")
Severity: Minor
Found in bin/check-mailgun-stats.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

      if !item.nil?
        if !tags.nil? && !tags.empty? && !(tags.length == 1 && tags[0] == '')
          tags.map { |tag| item['items'][0]['tags'][tag] }.select { |v| !v.nil? }.inject(0) { |a, e| a + e }
        else
          item['items'][0]['total_count']
Severity: Major
Found in bin/metrics-mailgun-stats.rb and 1 other location - About 1 hr to fix
bin/check-mailgun-stats.rb on lines 132..139

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 58.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

      if !item.nil?
        if !tags.nil? && !tags.empty? && !(tags.length == 1 && tags[0] == '')
          tags.map { |tag| item['items'][0]['tags'][tag] }.select { |v| !v.nil? }.inject(0) { |a, e| a + e }
        else
          item['items'][0]['total_count']
Severity: Major
Found in bin/check-mailgun-stats.rb and 1 other location - About 1 hr to fix
bin/metrics-mailgun-stats.rb on lines 100..107

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 58.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method total_sent has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

  def total_sent(domains, mailgun_key, events, tags)
    sent = domains.map do |domain|
      begin
        event_values = events.map { |e| "event=#{e}" }.join('&')
        uri = URI("https://api.mailgun.net/v3/#{domain}/stats?#{event_values}&limit=1")
Severity: Minor
Found in bin/metrics-mailgun-stats.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method total_sent has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def total_sent(domains, mailgun_key, events, tags)
    sent = domains.map do |domain|
      begin
        event_values = events.map { |e| "event=#{e}" }.join('&')
        uri = URI("https://api.mailgun.net/v3/#{domain}/stats?#{event_values}&limit=1")
Severity: Minor
Found in bin/metrics-mailgun-stats.rb - About 1 hr to fix

    Method gettotal_sen has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def gettotal_sen(domains, mailgun_key, events, tags, start_date)
    sent = domains.map do |domain|
      begin
        start_date_string = !start_date.nil? ? "&#{start_date}" : ''
        uri = URI("https://api.mailgun.net/v3/#{domain}/stats?#{events.map { |e| "event=#{e}" }.join('&')}&limit=1#{start_date_string}")
    Severity: Minor
    Found in bin/check-mailgun-stats.rb - About 1 hr to fix

      Method run has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        def run
    curr_time = TZInfo::Timezone.get(config[:timezone]).now
    if curr_time.hour != config[:hour_of_day]
      ok
    end
      Severity: Minor
      Found in bin/check-mailgun-stats.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method gettotal_sen has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        def gettotal_sen(domains, mailgun_key, events, tags, start_date)
      Severity: Minor
      Found in bin/check-mailgun-stats.rb - About 35 mins to fix
        Severity
        Category
        Status
        Source
        Language