Sign upLogin

sensu-plugins/sensu-plugins-netscaler

View on GitHub
Star

Showing 6 of 6 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    try:
      response = requests.get(url, auth=(user, password))
    except Exception as e:
      logger.critical('Could not get JSON from %s' % url)
      logger.critical(e)
Severity: Major
Found in bin/metrics-netscaler.py and 1 other location - About 2 hrs to fix
bin/metrics-netscaler.py on lines 102..107

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  try:
    response = requests.get(url, auth=(user, password))
  except Exception as e:
    logger.critical('Could not get JSON from %s' % url)
    logger.critical(e)
Severity: Major
Found in bin/metrics-netscaler.py and 1 other location - About 2 hrs to fix
bin/metrics-netscaler.py on lines 84..89

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function get_stats_with_ids has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

def get_stats_with_ids(stat_with_ids_end_point, stat_identifier, nitro_version,
Severity: Major
Found in bin/metrics-netscaler.py - About 50 mins to fix

    Function get_flat_stats has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def get_flat_stats(flat_stats_end_points, nitro_version, netscaler, user,
    Severity: Minor
    Found in bin/metrics-netscaler.py - About 45 mins to fix

      Function get_flat_stats has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      def get_flat_stats(flat_stats_end_points, nitro_version, netscaler, user,
    password, logger):
  nitro_rest_api = 'http://%s/nitro/%s/stat/' % (netscaler, nitro_version)
  flat_stats = {}
  for flat_stat_end_point in flat_stats_end_points:
      Severity: Minor
      Found in bin/metrics-netscaler.py - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function get_stats_with_ids has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      def get_stats_with_ids(stat_with_ids_end_point, stat_identifier, nitro_version,
    netscaler, user, password, logger):
  nitro_rest_api = 'http://%s/nitro/%s/stat/' % (netscaler, nitro_version)
  url = nitro_rest_api + stat_with_ids_end_point
  stats_with_ids = {}
      Severity: Minor
      Found in bin/metrics-netscaler.py - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language