Sign upLogin

sensu-plugins/sensu-plugins-netscaler

View on GitHub
Star

Showing 4 of 6 total issues

Function get_stats_with_ids has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

def get_stats_with_ids(stat_with_ids_end_point, stat_identifier, nitro_version,
Severity: Major
Found in bin/metrics-netscaler.py - About 50 mins to fix

    Function get_flat_stats has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def get_flat_stats(flat_stats_end_points, nitro_version, netscaler, user,
    Severity: Minor
    Found in bin/metrics-netscaler.py - About 45 mins to fix

      Function get_flat_stats has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      def get_flat_stats(flat_stats_end_points, nitro_version, netscaler, user,
    password, logger):
  nitro_rest_api = 'http://%s/nitro/%s/stat/' % (netscaler, nitro_version)
  flat_stats = {}
  for flat_stat_end_point in flat_stats_end_points:
      Severity: Minor
      Found in bin/metrics-netscaler.py - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function get_stats_with_ids has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      def get_stats_with_ids(stat_with_ids_end_point, stat_identifier, nitro_version,
    netscaler, user, password, logger):
  nitro_rest_api = 'http://%s/nitro/%s/stat/' % (netscaler, nitro_version)
  url = nitro_rest_api + stat_with_ids_end_point
  stats_with_ids = {}
      Severity: Minor
      Found in bin/metrics-netscaler.py - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language