sensu-plugins/sensu-plugins-postgres

View on GitHub

Showing 23 of 23 total issues

Method run has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run
    ssl_mode = config[:ssl] ? 'require' : 'prefer'

    critical 'Master and slave cannot be the same host' if config[:master_host] == config[:slave_host]

Severity: Minor
Found in bin/check-postgres-replication.rb - About 1 hr to fix

    Method run has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def run
        timestamp = Time.now.to_i
        pgpass
        con = PG.connect(host: config[:hostname],
                         dbname: config[:database],
    Severity: Minor
    Found in bin/metric-postgres-connections.rb - About 1 hr to fix

      Method run has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

        def run
          timestamp = Time.now.to_i
          pgpass
          con = PG.connect(host: config[:hostname],
                           dbname: config[:database],
      Severity: Minor
      Found in bin/metric-postgres-vaccum.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method run has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def run
          begin
            pgpass
            con = PG.connect(host: config[:hostname],
                             dbname: config[:database],
      Severity: Minor
      Found in bin/check-postgres-connections.rb - About 1 hr to fix

        Method run has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def run
            ssl_mode = config[:ssl] ? 'require' : 'prefer'
        
            # Establishing connections to the master
            pgpass
        Severity: Minor
        Found in bin/metric-postgres-graphite.rb - About 1 hr to fix

          Method run has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

            def run
              begin
                pgpass
                con = PG.connect(host: config[:hostname],
                                 dbname: config[:database],
          Severity: Minor
          Found in bin/check-postgres-connections.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method run has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def run
              timestamp = Time.now.to_i
              pgpass
              con = PG.connect(host: config[:hostname],
                               dbname: 'postgres',
          Severity: Minor
          Found in bin/metric-postgres-statsbgwriter.rb - About 1 hr to fix

            Method run has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def run
                timestamp = Time.now.to_i
                pgpass
                con = PG.connect(host: config[:hostname],
                                 dbname: config[:database],
            Severity: Minor
            Found in bin/metric-postgres-statstable.rb - About 1 hr to fix

              Method run has 28 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                def run
                  timestamp = Time.now.to_i
                  pgpass
                  con = PG.connect(host: config[:hostname],
                                   dbname: config[:database],
              Severity: Minor
              Found in bin/metric-postgres-statsio.rb - About 1 hr to fix

                Method run has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  def run
                    timestamp = Time.now.to_i
                    pgpass
                    con = PG.connect(host: config[:hostname],
                                     dbname: config[:database],
                Severity: Minor
                Found in bin/metric-postgres-vaccum.rb - About 1 hr to fix

                  Method pgpass has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                    def pgpass
                      if File.file?(config[:pgpass])
                        pgpass = Hash[%i[hostname port database user password].zip(read_pgpass(config[:pgpass]))]
                        pgpass[:database] = nil if pgpass[:database] == '*'
                        pgpass.each do |k, v|
                  Severity: Minor
                  Found in lib/sensu-plugins-postgres/pgpass.rb - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method run has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                    def run
                      ssl_mode = config[:ssl] ? 'require' : 'prefer'
                  
                      critical 'Master and slave cannot be the same host' if config[:master_host] == config[:slave_host]
                  
                  
                  Severity: Minor
                  Found in bin/check-postgres-replication.rb - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method run has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    def run
                      begin
                        pgpass
                        con = PG.connect(host: config[:hostname],
                                         dbname: config[:database],
                  Severity: Minor
                  Found in bin/check-postgres-query.rb - About 1 hr to fix

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                        begin
                          pgpass
                          con = PG.connect(host: config[:hostname],
                                           dbname: config[:database],
                                           user: config[:user],
                    Severity: Major
                    Found in bin/metrics-postgres-query.rb and 1 other location - About 1 hr to fix
                    bin/check-postgres-query.rb on lines 111..122

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 49.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                        begin
                          pgpass
                          con = PG.connect(host: config[:hostname],
                                           dbname: config[:database],
                                           user: config[:user],
                    Severity: Major
                    Found in bin/check-postgres-query.rb and 1 other location - About 1 hr to fix
                    bin/metrics-postgres-query.rb on lines 103..114

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 49.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Method run has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                      def run
                        begin
                          pgpass
                          con = PG.connect(host: config[:hostname],
                                           dbname: config[:database],
                    Severity: Minor
                    Found in bin/check-postgres-query.rb - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method run has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                    Open

                      def run
                        timestamp = Time.now.to_i
                        pgpass
                        con = PG.connect(host: config[:hostname],
                                         dbname: config[:database],
                    Severity: Minor
                    Found in bin/metric-postgres-statsdb.rb - About 35 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method run has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                      def run
                        ssl_mode = config[:ssl] ? 'require' : 'prefer'
                    
                        # Establishing connections to the master
                        pgpass
                    Severity: Minor
                    Found in bin/metric-postgres-graphite.rb - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Similar blocks of code found in 4 locations. Consider refactoring.
                    Open

                        conn_master = PG.connect(host: config[:master_host],
                                                 dbname: config[:database],
                                                 user: config[:user],
                                                 password: config[:password],
                                                 port: config[:port],
                    Severity: Minor
                    Found in bin/check-postgres-replication.rb and 3 other locations - About 25 mins to fix
                    bin/check-postgres-replication.rb on lines 131..137
                    bin/metric-postgres-graphite.rb on lines 101..107
                    bin/metric-postgres-graphite.rb on lines 118..124

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 30.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 4 locations. Consider refactoring.
                    Open

                        conn_slave = PG.connect(host: config[:slave_host],
                                                dbname: config[:database],
                                                user: config[:user],
                                                password: config[:password],
                                                port: config[:port],
                    Severity: Minor
                    Found in bin/check-postgres-replication.rb and 3 other locations - About 25 mins to fix
                    bin/check-postgres-replication.rb on lines 114..120
                    bin/metric-postgres-graphite.rb on lines 101..107
                    bin/metric-postgres-graphite.rb on lines 118..124

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 30.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Severity
                    Category
                    Status
                    Source
                    Language