Sign upLogin

sensu-plugins/sensu-plugins-sms

View on GitHub
Star

Showing 2 of 2 total issues

Method handle has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

  def handle
    @settings_key = 'free_sms_alert'
    @settings_key = ARGV[0] if ARGV.empty? == false
    smtp_address = settings['free_sms_alert']['smtp_address'] || 'localhost'
    smtp_port = settings['free_sms_alert']['smtp_port'] || '25'
Severity: Minor
Found in bin/handler-freesmsalert.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method handle has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def handle
    @settings_key = 'free_sms_alert'
    @settings_key = ARGV[0] if ARGV.empty? == false
    smtp_address = settings['free_sms_alert']['smtp_address'] || 'localhost'
    smtp_port = settings['free_sms_alert']['smtp_port'] || '25'
Severity: Minor
Found in bin/handler-freesmsalert.rb - About 1 hr to fix
    Severity
    Category
    Status
    Source
    Language