Sign upLogin

sensu/sensu-settings

View on GitHub
Star

Showing 26 of 26 total issues

Class Loader has 33 methods (exceeds 20 allowed). Consider refactoring.
Open

    class Loader
      class Error < RuntimeError; end

      # @!attribute [r] warnings
      #   @return [Array] loader warnings.
Severity: Minor
Found in lib/sensu/settings/loader.rb - About 4 hrs to fix

    File loader.rb has 303 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require "sensu/settings/validator"
require "sensu/json"
require "tmpdir"
require "socket"
require "digest"
    Severity: Minor
    Found in lib/sensu/settings/loader.rb - About 3 hrs to fix

      Method load_file has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

            def load_file(file, must_exist=true)
        if File.file?(file) && File.readable?(file)
          begin
            warning("loading config file", :file => file)
            contents = read_config_file(file)
      Severity: Minor
      Found in lib/sensu/settings/loader.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method validate_api_endpoints has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

              def validate_api_endpoints(api)
          if is_an_array?(api[:endpoints])
            api[:endpoints].each do |endpoint|
              if is_a_hash?(endpoint)
                if endpoint[:url]
      Severity: Minor
      Found in lib/sensu/settings/validators/api.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method validate_time_windows_days has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

              def validate_time_windows_days(definition, scope, attribute, days)
          valid_days = [:all, :sunday, :monday, :tuesday, :wednesday, :thursday, :friday, :saturday]
          if must_be_either(valid_days, days.keys)
            days.each do |day, conditions|
              if is_an_array?(conditions)
      Severity: Minor
      Found in lib/sensu/settings/validators/time_window.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method load_file has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def load_file(file, must_exist=true)
        if File.file?(file) && File.readable?(file)
          begin
            warning("loading config file", :file => file)
            contents = read_config_file(file)
      Severity: Minor
      Found in lib/sensu/settings/loader.rb - About 1 hr to fix

        Method validate_check_scheduling has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

                def validate_check_scheduling(check)
          must_be_boolean_if_set(check[:publish]) ||
            invalid(check, "check publish must be boolean")
          unless check[:publish] == false
            if check[:cron]
        Severity: Minor
        Found in lib/sensu/settings/validators/check.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method validate_check_aggregate has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

                def validate_check_aggregate(check)
          if check[:aggregates]
            if is_an_array?(check[:aggregates])
              items_must_be_strings(check[:aggregates], /\A[\w\.:|-]+\z/) ||
                invalid(check, "check aggregates items must be strings without spaces or special characters")
        Severity: Minor
        Found in lib/sensu/settings/validators/check.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method validate_time_windows has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

                def validate_time_windows(definition, scope, attribute)
          if is_a_hash?(definition[attribute])
            days = definition[attribute][:days]
            if is_a_hash?(days)
              if !days.empty?
        Severity: Minor
        Found in lib/sensu/settings/validators/time_window.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method validate_categories has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

              def validate_categories(settings)
        CATEGORIES.each do |category|
          if is_a_hash?(settings[category])
            validate_method = ("validate_" + category.to_s.chop).to_sym
            settings[category].each do |name, details|
        Severity: Minor
        Found in lib/sensu/settings/validator.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

                def validate_sensu_keepalives_handlers(sensu)
          must_be_a_string_if_set(sensu[:keepalives][:handler]) ||
            invalid(sensu, "sensu keepalives handler must be a string")
          must_be_an_array_if_set(sensu[:keepalives][:handlers]) ||
            invalid(sensu, "sensu keepalives handlers must be an array")
        Severity: Major
        Found in lib/sensu/settings/validators/sensu.rb and 3 other locations - About 45 mins to fix
        lib/sensu/settings/validators/client.rb on lines 83..91
        lib/sensu/settings/validators/client.rb on lines 155..163
        lib/sensu/settings/validators/client.rb on lines 184..192

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 39.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

                def validate_client_keepalive_handlers(client)
          must_be_a_string_if_set(client[:keepalive][:handler]) ||
            invalid(client, "client keepalive handler must be a string")
          must_be_an_array_if_set(client[:keepalive][:handlers]) ||
            invalid(client, "client keepalive handlers must be an array")
        Severity: Major
        Found in lib/sensu/settings/validators/client.rb and 3 other locations - About 45 mins to fix
        lib/sensu/settings/validators/client.rb on lines 155..163
        lib/sensu/settings/validators/client.rb on lines 184..192
        lib/sensu/settings/validators/sensu.rb on lines 43..51

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 39.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

                def validate_client_deregistration_handlers(client)
          must_be_a_string_if_set(client[:deregistration][:handler]) ||
            invalid(client, "client deregistration handler must be a string")
          must_be_an_array_if_set(client[:deregistration][:handlers]) ||
            invalid(client, "client deregistration handlers must be an array")
        Severity: Major
        Found in lib/sensu/settings/validators/client.rb and 3 other locations - About 45 mins to fix
        lib/sensu/settings/validators/client.rb on lines 83..91
        lib/sensu/settings/validators/client.rb on lines 155..163
        lib/sensu/settings/validators/sensu.rb on lines 43..51

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 39.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

                def validate_client_registration_handlers(client)
          must_be_a_string_if_set(client[:registration][:handler]) ||
            invalid(client, "client registration handler must be a string")
          must_be_an_array_if_set(client[:registration][:handlers]) ||
            invalid(client, "client registration handlers must be an array")
        Severity: Major
        Found in lib/sensu/settings/validators/client.rb and 3 other locations - About 45 mins to fix
        lib/sensu/settings/validators/client.rb on lines 83..91
        lib/sensu/settings/validators/client.rb on lines 184..192
        lib/sensu/settings/validators/sensu.rb on lines 43..51

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 39.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method validate_check_proxy_requests has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

                def validate_check_proxy_requests(check)
          if is_a_hash?(check[:proxy_requests])
            proxy_requests = check[:proxy_requests]
            must_be_a_hash(proxy_requests[:client_attributes]) ||
              invalid(check, "check proxy_requests client_attributes must be a hash")
        Severity: Minor
        Found in lib/sensu/settings/validators/check.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method load has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

              def load(options={})
        loader = Loader.new
        loader.load_env
        if options[:config_file]
          loader.load_file(options[:config_file], false)
        Severity: Minor
        Found in lib/sensu/settings.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                def validate_client_keepalive_thresholds(client)
          thresholds = client[:keepalive][:thresholds]
          must_be_a_hash_if_set(thresholds) ||
            invalid(client, "client keepalive thresholds must be a hash")
          if is_a_hash?(thresholds)
        Severity: Minor
        Found in lib/sensu/settings/validators/client.rb and 1 other location - About 35 mins to fix
        lib/sensu/settings/validators/sensu.rb on lines 27..36

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 34.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                def validate_sensu_keepalives_thresholds(sensu)
          thresholds = sensu[:keepalives][:thresholds]
          must_be_a_hash_if_set(thresholds) ||
            invalid(sensu, "sensu keepalives thresholds must be a hash")
          if is_a_hash?(thresholds)
        Severity: Minor
        Found in lib/sensu/settings/validators/sensu.rb and 1 other location - About 35 mins to fix
        lib/sensu/settings/validators/client.rb on lines 98..107

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 34.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    must_be_boolean_if_set(client[:socket][:enabled]) ||
              invalid(client, "client socket enabled must be a boolean")
            must_be_a_string_if_set(client[:socket][:bind]) ||
              invalid(client, "client socket bind must be a string")
            must_be_an_integer_if_set(client[:socket][:port]) ||
        Severity: Minor
        Found in lib/sensu/settings/validators/client.rb and 1 other location - About 25 mins to fix
        lib/sensu/settings/validators/sensu.rb on lines 73..79

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 31.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    must_be_a_string_if_set(sensu[:server][:results_pipe]) ||
              invalid(sensu, "sensu server results_pipe must be a string")
            must_be_a_string_if_set(sensu[:server][:keepalives_pipe]) ||
              invalid(sensu, "sensu server keepalives_pipe must be a string")
            must_be_an_integer_if_set(sensu[:server][:max_message_size]) ||
        Severity: Minor
        Found in lib/sensu/settings/validators/sensu.rb and 1 other location - About 25 mins to fix
        lib/sensu/settings/validators/client.rb on lines 35..41

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 31.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Severity
        Category
        Status
        Source
        Language