Sign upLogin

sensu/sensu-transport

View on GitHub
Star

Showing 13 of 13 total issues

Method publish has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

      def publish(type, pipe, message, options={})
        if connected?
          catch_errors do
            channel = (pipe == "keepalives" ? @primary_channel : @secondary_channel)
            channel.method(type.to_sym).call(pipe, options).publish(message) do
Severity: Minor
Found in lib/sensu/transport/rabbitmq.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method pubsub_subscribe has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

      def pubsub_subscribe(pipe)
        channel = redis_key("channel", pipe)
        redis_connection("pubsub") do |connection|
          connection.subscribe(channel) do |type, channel, message|
            case type
Severity: Minor
Found in lib/sensu/transport/redis.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method setup_connection has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def setup_connection(options={}, &callback)
        reconnect_callback = Proc.new { reconnect }
        on_possible_auth_failure = Proc.new {
          @logger.warn("transport connection error", {
            :reason => "possible authentication failure. wrong credentials?",
Severity: Minor
Found in lib/sensu/transport/rabbitmq.rb - About 1 hr to fix

    Method resolve_hostname has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

          def resolve_hostname(host, &callback)
        resolve = Proc.new do
          begin
            info = case RUBY_PLATFORM
            when /linux/
    Severity: Minor
    Found in lib/sensu/transport/base.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method periodically_reconnect has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

          def periodically_reconnect(delay=2)
        capped_delay = (delay >= 20 ? 20 : delay)
        EM::Timer.new(capped_delay) do
          unless connected?
            reset
    Severity: Minor
    Found in lib/sensu/transport/rabbitmq.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method next_connection_options has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

          def next_connection_options(&callback)
        if @eligible_options.nil? || @eligible_options.empty?
          @eligible_options = @connection_options.shuffle
        end
        options = @eligible_options.shift || {}
    Severity: Minor
    Found in lib/sensu/transport/rabbitmq.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method send_heartbeat has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def send_heartbeat
      if tcp_connection_established? && !reconnecting? && !closed?
        send_frame(AMQ::Protocol::HeartbeatFrame)
        if !@handling_skipped_heartbeats && @last_server_heartbeat
          if @last_server_heartbeat < (Time.now - (self.heartbeat_interval * 2))
    Severity: Minor
    Found in lib/sensu/transport/patches/amqp.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method subscribe has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

          def subscribe(type, pipe, funnel=nil, options={}, &callback)
    Severity: Minor
    Found in lib/sensu/transport/redis.rb - About 35 mins to fix

      Method publish has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

            def publish(type, pipe, message, options={}, &callback)
      Severity: Minor
      Found in lib/sensu/transport/redis.rb - About 35 mins to fix

        Method subscribe has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

              def subscribe(type, pipe, funnel="", options={}, &callback)
        Severity: Minor
        Found in lib/sensu/transport/rabbitmq.rb - About 35 mins to fix

          Method unsubscribe has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

                def unsubscribe
        catch_errors do
          @queues.values.each do |queue|
            if connected?
              queue.unsubscribe
          Severity: Minor
          Found in lib/sensu/transport/rabbitmq.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                def list_publish(pipe, message)
        list = redis_key("list", pipe)
        redis_connection("redis") do |connection|
          connection.rpush(list, message) do |queued|
            info = {:queued => queued}
          Severity: Minor
          Found in lib/sensu/transport/redis.rb and 1 other location - About 15 mins to fix
          lib/sensu/transport/redis.rb on lines 231..237

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 25.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                def pubsub_publish(pipe, message)
        channel = redis_key("channel", pipe)
        redis_connection("redis") do |connection|
          connection.publish(channel, message) do |subscribers|
            info = {:subscribers => subscribers}
          Severity: Minor
          Found in lib/sensu/transport/redis.rb and 1 other location - About 15 mins to fix
          lib/sensu/transport/redis.rb on lines 285..291

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 25.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Severity
          Category
          Status
          Source
          Language