Sign upLogin

sensu/uchiwa

View on GitHub
Star

Showing 81 of 81 total issues

Similar blocks of code found in 4 locations. Consider refactoring.
Open

func (u *Uchiwa) findCheck(name string) ([]interface{}, error) {
    var checks []interface{}
    for _, c := range u.Data.Checks {
        m, ok := c.(map[string]interface{})
        if !ok {
Severity: Major
Found in uchiwa/check.go and 3 other locations - About 1 hr to fix
uchiwa/aggregate.go on lines 94..112
uchiwa/client.go on lines 50..68
uchiwa/stash.go on lines 48..66

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 162.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method Config.Login has 57 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (c *Config) Login() http.Handler {
    return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
        if r.Method == "POST" {
            decoder := json.NewDecoder(r.Body)
            var data interface{}
Severity: Minor
Found in uchiwa/authentication/controllers.go - About 1 hr to fix

    Method Uchiwa.checkHandler has a Cognitive Complexity of 26 (exceeds 20 allowed). Consider refactoring.
    Open

    func (u *Uchiwa) checkHandler(w http.ResponseWriter, r *http.Request) {
    // We only support DELETE & GET requests
    if r.Method != http.MethodGet && r.Method != http.MethodHead {
        http.Error(w, "", http.StatusBadRequest)
        return
    Severity: Minor
    Found in uchiwa/server.go - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function restrictedHandler has a Cognitive Complexity of 26 (exceeds 20 allowed). Consider refactoring.
    Open

    func restrictedHandler(next http.Handler) http.Handler {
    return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
        var token *jwt.Token
        authenticationToken, err := r.Cookie(authenticationCookieName)
        if err == nil {
    Severity: Minor
    Found in uchiwa/authentication/controllers.go - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method Uchiwa.checkHandler has 13 return statements (exceeds 4 allowed).
    Open

    func (u *Uchiwa) checkHandler(w http.ResponseWriter, r *http.Request) {
    // We only support DELETE & GET requests
    if r.Method != http.MethodGet && r.Method != http.MethodHead {
        http.Error(w, "", http.StatusBadRequest)
        return
    Severity: Major
    Found in uchiwa/server.go - About 1 hr to fix

      Function restrictedHandler has 56 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func restrictedHandler(next http.Handler) http.Handler {
    return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
        var token *jwt.Token
        authenticationToken, err := r.Cookie(authenticationCookieName)
        if err == nil {
      Severity: Minor
      Found in uchiwa/authentication/controllers.go - About 1 hr to fix

        Function findClientEvents has 55 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func findClientEvents(client map[string]interface{}, events *[]interface{}) map[string]interface{} {
    if len(*events) == 0 {
        client["status"] = 0
    } else {
        var criticals, warnings int
        Severity: Minor
        Found in uchiwa/daemon/clients.go - About 1 hr to fix

          Method Uchiwa.eventHandler has 12 return statements (exceeds 4 allowed).
          Open

          func (u *Uchiwa) eventHandler(w http.ResponseWriter, r *http.Request) {
    if r.Method != http.MethodDelete {
        http.Error(w, "", http.StatusBadRequest)
        return
    }
          Severity: Major
          Found in uchiwa/server.go - About 1 hr to fix

            Method Uchiwa.stashHandler has 12 return statements (exceeds 4 allowed).
            Open

            func (u *Uchiwa) stashHandler(w http.ResponseWriter, r *http.Request) {
    if r.Method != http.MethodDelete {
        http.Error(w, "", http.StatusBadRequest)
        return
    }
            Severity: Major
            Found in uchiwa/server.go - About 1 hr to fix

              Method Uchiwa.resultsHandler has 12 return statements (exceeds 4 allowed).
              Open

              func (u *Uchiwa) resultsHandler(w http.ResponseWriter, r *http.Request) {
    if r.Method != http.MethodDelete {
        http.Error(w, "", http.StatusBadRequest)
        return
    }
              Severity: Major
              Found in uchiwa/server.go - About 1 hr to fix

                Method Uchiwa.silencedHandler has 12 return statements (exceeds 4 allowed).
                Open

                func (u *Uchiwa) silencedHandler(w http.ResponseWriter, r *http.Request) {
    token := authentication.GetJWTFromContext(r)

    if r.Method == http.MethodGet || r.Method == http.MethodHead {
        // GET on /silenced
                Severity: Major
                Found in uchiwa/server.go - About 1 hr to fix

                  Method Uchiwa.stashesHandler has 51 lines of code (exceeds 50 allowed). Consider refactoring.
                  Open

                  func (u *Uchiwa) stashesHandler(w http.ResponseWriter, r *http.Request) {
    token := authentication.GetJWTFromContext(r)

    if r.Method == http.MethodGet || r.Method == http.MethodHead {
        // GET on /stashes
                  Severity: Minor
                  Found in uchiwa/server.go - About 1 hr to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                    func (u *Uchiwa) GetAggregateClients(name, dc string) (*[]interface{}, error) {
    api, err := getAPI(u.Datacenters, dc)
    if err != nil {
        logger.Warning(err)
        return nil, err
                    Severity: Major
                    Found in uchiwa/aggregate.go and 1 other location - About 1 hr to fix
                    uchiwa/aggregate.go on lines 44..58

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 131.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                    func (u *Uchiwa) GetAggregateChecks(name, dc string) (*[]interface{}, error) {
    api, err := getAPI(u.Datacenters, dc)
    if err != nil {
        logger.Warning(err)
        return nil, err
                    Severity: Major
                    Found in uchiwa/aggregate.go and 1 other location - About 1 hr to fix
                    uchiwa/aggregate.go on lines 61..75

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 131.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Method Uchiwa.stashHandler has a Cognitive Complexity of 24 (exceeds 20 allowed). Consider refactoring.
                    Open

                    func (u *Uchiwa) stashHandler(w http.ResponseWriter, r *http.Request) {
    if r.Method != http.MethodDelete {
        http.Error(w, "", http.StatusBadRequest)
        return
    }
                    Severity: Minor
                    Found in uchiwa/server.go - About 55 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method Uchiwa.clientsHandler has 9 return statements (exceeds 4 allowed).
                    Open

                    func (u *Uchiwa) clientsHandler(w http.ResponseWriter, r *http.Request) {
    // Support GET & HEAD requests
    if r.Method == http.MethodGet || r.Method == http.MethodHead {
        token := authentication.GetJWTFromContext(r)
                    Severity: Major
                    Found in uchiwa/server.go - About 55 mins to fix

                      Method Uchiwa.stashesHandler has 8 return statements (exceeds 4 allowed).
                      Open

                      func (u *Uchiwa) stashesHandler(w http.ResponseWriter, r *http.Request) {
    token := authentication.GetJWTFromContext(r)

    if r.Method == http.MethodGet || r.Method == http.MethodHead {
        // GET on /stashes
                      Severity: Major
                      Found in uchiwa/server.go - About 50 mins to fix

                        Method API.doRequest has 8 return statements (exceeds 4 allowed).
                        Open

                        func (api *API) doRequest(req *http.Request) ([]byte, *http.Response, error) {
    if api.User != "" && api.Pass != "" {
        req.SetBasicAuth(api.User, api.Pass)
    }
                        Severity: Major
                        Found in uchiwa/sensu/request.go - About 50 mins to fix

                          Similar blocks of code found in 3 locations. Consider refactoring.
                          Open

                          func (u *Uchiwa) PostStash(data stash) error {
    api, err := getAPI(u.Datacenters, data.Dc)
    if err != nil {
        logger.Warning(err)
        return err
                          Severity: Major
                          Found in uchiwa/stash.go and 2 other locations - About 50 mins to fix
                          uchiwa/silenced.go on lines 18..32
                          uchiwa/silenced.go on lines 35..49

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 120.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                          package uchiwa

import "github.com/sensu/uchiwa/uchiwa/logger"

// ResolveEvent sends a DELETE request in order to
                          Severity: Minor
                          Found in uchiwa/event.go and 1 other location - About 50 mins to fix
                          uchiwa/results.go on lines 1..21

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 120.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Severity
                          Category
                          Status
                          Source
                          Language