Sign upLogin

sentilo/sentilo

View on GitHub
Star

Showing 593 of 1,220 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                aaSort = ( oSettings.aaSortingFixed !== null ) ?
                    oSettings.aaSortingFixed.concat( oSettings.aaSorting ) :
                    oSettings.aaSorting.slice();
Severity: Minor
Found in sentilo-catalog-web/src/main/webapp/static/js/jquery.dataTables.js and 1 other location - About 35 mins to fix
sentilo-catalog-web/src/main/webapp/static/js/jquery.dataTables.js on lines 1953..1955

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

            } else if (dataType === 'IMAGE_LINK') {
                addAccordionGroup(accordion, accordionId, dataType, header, e, imageWrapperIdPrefix);
                tempSensorLastObsMap.image.push({
                    value: value,
                    formattedValue: formattedValue,
Severity: Major
Found in sentilo-catalog-web/src/main/webapp/static/js/sentilo/universal_map.js and 4 other locations - About 35 mins to fix
sentilo-catalog-web/src/main/webapp/static/js/sentilo/universal_map.js on lines 743..778
sentilo-catalog-web/src/main/webapp/static/js/sentilo/universal_map.js on lines 750..778
sentilo-catalog-web/src/main/webapp/static/js/sentilo/universal_map.js on lines 764..778
sentilo-catalog-web/src/main/webapp/static/js/sentilo/universal_map.js on lines 771..778

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            if ( thead.length === 0 )
            {
                thead = [ document.createElement( 'thead' ) ];
                this.appendChild( thead[0] );
            }
Severity: Minor
Found in sentilo-catalog-web/src/main/webapp/static/js/jquery.dataTables.js and 1 other location - About 35 mins to fix
sentilo-catalog-web/src/main/webapp/static/js/jquery.dataTables.js on lines 6744..6748

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                s = axis.scale = plotHeight / Math.abs(t(axis.max) - t(axis.min));
Severity: Minor
Found in sentilo-catalog-web/src/main/webapp/static/js/jquery.flot.js and 1 other location - About 35 mins to fix
sentilo-catalog-web/src/main/webapp/static/js/jquery.flot.js on lines 937..937

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  var tr = new google.maps.LatLng(bounds.getNorthEast().lat(),
      bounds.getNorthEast().lng());
Severity: Minor
Found in sentilo-catalog-web/src/main/webapp/static/js/markerclusterer.js and 1 other location - About 35 mins to fix
sentilo-catalog-web/src/main/webapp/static/js/markerclusterer.js on lines 1345..1346

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  var bl = new google.maps.LatLng(bounds.getSouthWest().lat(),
      bounds.getSouthWest().lng());
Severity: Minor
Found in sentilo-catalog-web/src/main/webapp/static/js/markerclusterer.js and 1 other location - About 35 mins to fix
sentilo-catalog-web/src/main/webapp/static/js/markerclusterer.js on lines 1343..1344

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                    if ( expandedFunction !== nonExpandedFunction ) {
                        result += processJsonPrimitive( 'function', nonExpandedFunction, expandedFunction );
                        isToggleable = true;
                    } else {
                        result += processJsonPrimitive( 'function', nonExpandedFunction );
Severity: Minor
Found in sentilo-catalog-web/src/main/webapp/static/js/jquery.jsonPresenter.js and 1 other location - About 35 mins to fix
sentilo-catalog-web/src/main/webapp/static/js/jquery.jsonPresenter.js on lines 175..180

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            if ( tbody.length === 0 )
            {
                tbody = [ document.createElement( 'tbody' ) ];
                this.appendChild( tbody[0] );
            }
Severity: Minor
Found in sentilo-catalog-web/src/main/webapp/static/js/jquery.dataTables.js and 1 other location - About 35 mins to fix
sentilo-catalog-web/src/main/webapp/static/js/jquery.dataTables.js on lines 6736..6740

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                s = axis.scale = plotWidth / Math.abs(t(axis.max) - t(axis.min));
Severity: Minor
Found in sentilo-catalog-web/src/main/webapp/static/js/jquery.flot.js and 1 other location - About 35 mins to fix
sentilo-catalog-web/src/main/webapp/static/js/jquery.flot.js on lines 941..941

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                    if ( displayValue !== alternateDisplayValue ) {
                        result += processJsonPrimitive( 'string', displayValue, alternateDisplayValue );
                        isToggleable = true;
                    } else {
                        result += processJsonPrimitive( 'string', displayValue );
Severity: Minor
Found in sentilo-catalog-web/src/main/webapp/static/js/jquery.jsonPresenter.js and 1 other location - About 35 mins to fix
sentilo-catalog-web/src/main/webapp/static/js/jquery.jsonPresenter.js on lines 161..166

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  @Override
  public Sensor findByName(final String providerId, final String sensorId) {
    final SearchFilter filter = new SearchFilter();
    filter.addAndParam("providerId", providerId);
    filter.addAndParam("sensorId", sensorId);
Severity: Minor
Found in sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/service/impl/SensorServiceImpl.java and 2 other locations - About 35 mins to fix
sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/service/impl/ComponentServiceImpl.java on lines 92..99
sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/service/impl/ComponentServiceImpl.java on lines 172..178

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  private RedisScript<List> getSlidingWindowScript() {
    if (slidingWindowScript == null) {
      slidingWindowScript = new DefaultRedisScript<List>();
      slidingWindowScript.setScriptSource(new ResourceScriptSource(new ClassPathResource("scripts/rl_sliding_window.lua")));
      slidingWindowScript.setResultType(List.class);
Severity: Major
Found in sentilo-platform/sentilo-platform-common/src/main/java/org/sentilo/platform/common/ratelimiter/service/RedisSlidingWindowServiceImpl.java and 3 other locations - About 35 mins to fix
sentilo-platform/sentilo-platform-common/src/main/java/org/sentilo/platform/common/ratelimiter/service/RedisSlidingWindowServiceImpl.java on lines 209..217
sentilo-platform/sentilo-platform-common/src/main/java/org/sentilo/platform/common/ratelimiter/service/RedisTokenBucketServiceImpl.java on lines 207..215
sentilo-platform/sentilo-platform-common/src/main/java/org/sentilo/platform/common/ratelimiter/service/RedisTokenBucketServiceImpl.java on lines 217..225

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  @Override
  public List<Component> findByType(final String providerId, final String componentType) {
    final SearchFilter filter = new SearchFilter();
    filter.addAndParam("providerId", providerId);
    filter.addAndParam("componentType", componentType);
Severity: Minor
Found in sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/service/impl/ComponentServiceImpl.java and 2 other locations - About 35 mins to fix
sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/service/impl/ComponentServiceImpl.java on lines 92..99
sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/service/impl/SensorServiceImpl.java on lines 238..245

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  private RedisScript<List> getSlidingWindowStatusScript() {
    if (slidingWindowStatusScript == null) {
      slidingWindowStatusScript = new DefaultRedisScript<List>();
      slidingWindowStatusScript.setScriptSource(new ResourceScriptSource(new ClassPathResource("scripts/rl_sliding_window_status.lua")));
      slidingWindowStatusScript.setResultType(List.class);
Severity: Major
Found in sentilo-platform/sentilo-platform-common/src/main/java/org/sentilo/platform/common/ratelimiter/service/RedisSlidingWindowServiceImpl.java and 3 other locations - About 35 mins to fix
sentilo-platform/sentilo-platform-common/src/main/java/org/sentilo/platform/common/ratelimiter/service/RedisSlidingWindowServiceImpl.java on lines 199..207
sentilo-platform/sentilo-platform-common/src/main/java/org/sentilo/platform/common/ratelimiter/service/RedisTokenBucketServiceImpl.java on lines 207..215
sentilo-platform/sentilo-platform-common/src/main/java/org/sentilo/platform/common/ratelimiter/service/RedisTokenBucketServiceImpl.java on lines 217..225

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  private RedisScript<List> getTokenBucketStatusScript() {
    if (tokenBucketStatusScript == null) {
      tokenBucketStatusScript = new DefaultRedisScript<List>();
      tokenBucketStatusScript.setScriptSource(new ResourceScriptSource(new ClassPathResource("scripts/rl_token_bucket_status.lua")));
      tokenBucketStatusScript.setResultType(List.class);
Severity: Major
Found in sentilo-platform/sentilo-platform-common/src/main/java/org/sentilo/platform/common/ratelimiter/service/RedisTokenBucketServiceImpl.java and 3 other locations - About 35 mins to fix
sentilo-platform/sentilo-platform-common/src/main/java/org/sentilo/platform/common/ratelimiter/service/RedisSlidingWindowServiceImpl.java on lines 199..207
sentilo-platform/sentilo-platform-common/src/main/java/org/sentilo/platform/common/ratelimiter/service/RedisSlidingWindowServiceImpl.java on lines 209..217
sentilo-platform/sentilo-platform-common/src/main/java/org/sentilo/platform/common/ratelimiter/service/RedisTokenBucketServiceImpl.java on lines 207..215

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  private RedisScript<List> getTokenBucketScript() {
    if (tokenBucketScript == null) {
      tokenBucketScript = new DefaultRedisScript<List>();
      tokenBucketScript.setScriptSource(new ResourceScriptSource(new ClassPathResource("scripts/rl_token_bucket.lua")));
      tokenBucketScript.setResultType(List.class);
Severity: Major
Found in sentilo-platform/sentilo-platform-common/src/main/java/org/sentilo/platform/common/ratelimiter/service/RedisTokenBucketServiceImpl.java and 3 other locations - About 35 mins to fix
sentilo-platform/sentilo-platform-common/src/main/java/org/sentilo/platform/common/ratelimiter/service/RedisSlidingWindowServiceImpl.java on lines 199..207
sentilo-platform/sentilo-platform-common/src/main/java/org/sentilo/platform/common/ratelimiter/service/RedisSlidingWindowServiceImpl.java on lines 209..217
sentilo-platform/sentilo-platform-common/src/main/java/org/sentilo/platform/common/ratelimiter/service/RedisTokenBucketServiceImpl.java on lines 217..225

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  @Override
  public Component findByName(final String providerId, final String name) {
    final SearchFilter filter = new SearchFilter();
    filter.addAndParam("providerId", providerId);
    filter.addAndParam("name", name);
Severity: Minor
Found in sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/service/impl/ComponentServiceImpl.java and 2 other locations - About 35 mins to fix
sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/service/impl/ComponentServiceImpl.java on lines 172..178
sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/service/impl/SensorServiceImpl.java on lines 238..245

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  @Override
  public void removeGrantedTenant(final String providerId, final String tenantId) {
    final Provider provider = findAndThrowErrorIfNotExist(new Provider(providerId));
    provider.getTenantsAuth().remove(tenantId);
    provider.getTenantsListVisible().remove(tenantId);
Severity: Minor
Found in sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/service/impl/ProviderServiceImpl.java and 1 other location - About 35 mins to fix
sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/service/impl/ProviderServiceImpl.java on lines 140..146

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  @Override
  public void addGrantedTenant(final String providerId, final String tenantId) {
    final Provider provider = findAndThrowErrorIfNotExist(new Provider(providerId));
    provider.getTenantsAuth().add(tenantId);
    provider.getTenantsListVisible().add(tenantId);
Severity: Minor
Found in sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/service/impl/ProviderServiceImpl.java and 1 other location - About 35 mins to fix
sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/service/impl/ProviderServiceImpl.java on lines 154..160

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  @SuppressWarnings("unchecked")
  private List<OptionDTO> addProviderListTo(final Model model) {
    final List<Provider> providers = (List<Provider>) getResourcesUserSectorsGranted(providerService);
    final List<OptionDTO> providersDTO = CatalogUtils.toOptionList(providers);
    model.addAttribute(Constants.MODEL_PROVIDERS, providersDTO);
Severity: Minor
Found in sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/controller/admin/SensorController.java and 1 other location - About 35 mins to fix
sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/controller/admin/ComponentController.java on lines 258..264

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language