Sign upLogin

sentilo/sentilo

View on GitHub
Star
sentilo-agent-alert/src/main/java/org/sentilo/agent/alert/trigger/TriggerEvaluator.java

Summary

Maintainability
C
1 day
Test Coverage

Method evaluate has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  public TriggerResult evaluate(final InternalAlert alert, final String value) {
    // GT, GTE, LT, LTE, EQ, CHANGE, CHANGE_DELTA
    LOGGER.debug("Evaluating alert {} with sensor value {}", alert.getId(), value);

    TriggerResult result = null;
Severity: Minor
Found in sentilo-agent-alert/src/main/java/org/sentilo/agent/alert/trigger/TriggerEvaluator.java - About 1 hr to fix

    Method evaluateChangeDeltaTrigger has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      private TriggerResult evaluateChangeDeltaTrigger(final InternalAlert alert, final String value) throws ParseException {
    TriggerResult result = null;

    // CHANGE_DELTA alert will publish a new alarm when the percent change between the current
    // sensor's value (B) and the previous published value (A) is greater than a configured delta.
    Severity: Minor
    Found in sentilo-agent-alert/src/main/java/org/sentilo/agent/alert/trigger/TriggerEvaluator.java - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      private TriggerResult evaluateGreaterThanOrEqualsTrigger(final InternalAlert alert, final String value) throws ParseException {
    TriggerResult result = null;

    if (!isNumberValue(value)) {
      result = new TriggerResult(String.format(Constants.TEMPLATE_NO_NUMBER_MESSAGE, alert.getId(), value, alert.getSensorId()));
    Severity: Major
    Found in sentilo-agent-alert/src/main/java/org/sentilo/agent/alert/trigger/TriggerEvaluator.java and 1 other location - About 1 hr to fix
    sentilo-agent-alert/src/main/java/org/sentilo/agent/alert/trigger/TriggerEvaluator.java on lines 138..149

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 99.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      private TriggerResult evaluateLessThanTrigger(final InternalAlert alert, final String value) throws ParseException {
    TriggerResult result = null;

    if (!isNumberValue(value)) {
      result = new TriggerResult(String.format(Constants.TEMPLATE_NO_NUMBER_MESSAGE, alert.getId(), value, alert.getSensorId()));
    Severity: Major
    Found in sentilo-agent-alert/src/main/java/org/sentilo/agent/alert/trigger/TriggerEvaluator.java and 1 other location - About 1 hr to fix
    sentilo-agent-alert/src/main/java/org/sentilo/agent/alert/trigger/TriggerEvaluator.java on lines 125..136

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 99.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      private TriggerResult evaluateLessThanOrEqualsTrigger(final InternalAlert alert, final String value) throws ParseException {
    TriggerResult result = null;

    if (!isNumberValue(value)) {
      result = new TriggerResult(String.format(Constants.TEMPLATE_NO_NUMBER_MESSAGE, alert.getId(), value, alert.getSensorId()));
    Severity: Major
    Found in sentilo-agent-alert/src/main/java/org/sentilo/agent/alert/trigger/TriggerEvaluator.java and 1 other location - About 1 hr to fix
    sentilo-agent-alert/src/main/java/org/sentilo/agent/alert/trigger/TriggerEvaluator.java on lines 112..123

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 97.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      private TriggerResult evaluateGreaterThanTrigger(final InternalAlert alert, final String value) throws ParseException {
    TriggerResult result = null;

    if (!isNumberValue(value)) {
      result = new TriggerResult(String.format(Constants.TEMPLATE_NO_NUMBER_MESSAGE, alert.getId(), value, alert.getSensorId()));
    Severity: Major
    Found in sentilo-agent-alert/src/main/java/org/sentilo/agent/alert/trigger/TriggerEvaluator.java and 1 other location - About 1 hr to fix
    sentilo-agent-alert/src/main/java/org/sentilo/agent/alert/trigger/TriggerEvaluator.java on lines 151..162

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 97.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status