Sign upLogin

sentilo/sentilo

View on GitHub
Star
sentilo-agent-relational/src/main/java/org/sentilo/agent/relational/repository/batch/BatchProcessWorker.java

Summary

Maintainability
C
1 day
Test Coverage

Method persistAlarms has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  private int persistAlarms(final List<EventMessage> alarms) {
    final BatchPreparedStatementSetter bpss = new BatchPreparedStatementSetter() {

      @Override
      public void setValues(final PreparedStatement ps, final int i) throws SQLException {
Severity: Minor
Found in sentilo-agent-relational/src/main/java/org/sentilo/agent/relational/repository/batch/BatchProcessWorker.java - About 1 hr to fix

    Method persistOrders has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      private int persistOrders(final List<EventMessage> orders) {

    final BatchPreparedStatementSetter bpss = new BatchPreparedStatementSetter() {

      @Override
    Severity: Minor
    Found in sentilo-agent-relational/src/main/java/org/sentilo/agent/relational/repository/batch/BatchProcessWorker.java - About 1 hr to fix

      Method persistObservations has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        private int persistObservations(final List<EventMessage> observations) {
    final BatchPreparedStatementSetter bpss = new BatchPreparedStatementSetter() {

      @Override
      public void setValues(final PreparedStatement ps, final int i) throws SQLException {
      Severity: Minor
      Found in sentilo-agent-relational/src/main/java/org/sentilo/agent/relational/repository/batch/BatchProcessWorker.java - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          private int persistOrders(final List<EventMessage> orders) {

    final BatchPreparedStatementSetter bpss = new BatchPreparedStatementSetter() {

      @Override
        Severity: Major
        Found in sentilo-agent-relational/src/main/java/org/sentilo/agent/relational/repository/batch/BatchProcessWorker.java and 1 other location - About 4 hrs to fix
        sentilo-agent-relational/src/main/java/org/sentilo/agent/relational/repository/batch/BatchProcessWorker.java on lines 208..239

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 248.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          private int persistObservations(final List<EventMessage> observations) {
    final BatchPreparedStatementSetter bpss = new BatchPreparedStatementSetter() {

      @Override
      public void setValues(final PreparedStatement ps, final int i) throws SQLException {
        Severity: Major
        Found in sentilo-agent-relational/src/main/java/org/sentilo/agent/relational/repository/batch/BatchProcessWorker.java and 1 other location - About 4 hrs to fix
        sentilo-agent-relational/src/main/java/org/sentilo/agent/relational/repository/batch/BatchProcessWorker.java on lines 139..171

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 248.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status