Sign upLogin

sentilo/sentilo

View on GitHub
Star
sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/controller/SearchController.java

Summary

Maintainability
C
7 hrs
Test Coverage

SearchController has 29 methods (exceeds 20 allowed). Consider refactoring.
Open

public abstract class SearchController<T extends CatalogDocument> extends CatalogBaseController implements SearchFilterResolver {

  protected static final String LIST_ACTION = "list";
  protected static final String EXCEL_VIEW = "excelView";
Severity: Minor
Found in sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/controller/SearchController.java - About 3 hrs to fix

    File SearchController.java has 264 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*
 * Sentilo
 *
 * Original version 1.4 Copyright (C) 2013 Institut Municipal d’Informàtica, Ajuntament de
 * Barcelona. Modified by Opentrends adding support for multitenant deployments and SaaS.
    Severity: Minor
    Found in sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/controller/SearchController.java - About 2 hrs to fix

      Method checkSectorGrant has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

        @SuppressWarnings("rawtypes")
  private void checkSectorGrant(final T resource, final Map<String, String> rowMetadata) {

    final boolean isSectorialUser =
        userDetailsService.getCatalogUserDetails() != null && userDetailsService.getCatalogUserDetails().isSectorialUser();
      Severity: Minor
      Found in sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/controller/SearchController.java - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method getPageList has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        public DataTablesDTO getPageList(final Model model, final HttpServletRequest request, final Pageable pageable, @RequestParam final Integer sEcho,
      @RequestParam final String tableName, @RequestParam(required = false) final String search) {
      Severity: Minor
      Found in sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/controller/SearchController.java - About 45 mins to fix

        There are no issues that match your filters.

        Category
        Status