Sign upLogin

sentilo/sentilo

View on GitHub
Star
sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/controller/admin/TenantPermissionsController.java

Summary

Maintainability
C
1 day
Test Coverage

TenantPermissionsController has 23 methods (exceeds 20 allowed). Consider refactoring.
Open

@Controller
@RequestMapping("/admin/grants")
public class TenantPermissionsController extends SearchController<TenantPermission> {

  private static final String PERMISSION = "permission.";
Severity: Minor
Found in sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/controller/admin/TenantPermissionsController.java - About 2 hrs to fix

    Method getTenantPermissions has 8 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      public DataTablesDTO getTenantPermissions(final HttpServletRequest request, final Model model, final Pageable pageable,
      @PathVariable final String type, @PathVariable final String id, @RequestParam final Integer sEcho, @RequestParam final String tableName,
      @RequestParam(required = false) final String search) {
    Severity: Major
    Found in sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/controller/admin/TenantPermissionsController.java - About 1 hr to fix

      Method createPermissions has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        private void createPermissions(final String tenantSource, final String[] tenantSourceEntitiesIds, final String[] tenantTargetsIds,
      final TenantPermission.Type type, final EntityType entityType, final boolean visible, final boolean listVisible) {
      Severity: Major
      Found in sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/controller/admin/TenantPermissionsController.java - About 50 mins to fix

        Method getTenantPermissionsExcel has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          public ModelAndView getTenantPermissionsExcel(final HttpServletRequest request, final Model model, final HttpServletResponse response,
      @PathVariable final String id, @RequestParam final String tableName, @RequestParam(required = false) final String search) throws IOException {
        Severity: Minor
        Found in sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/controller/admin/TenantPermissionsController.java - About 45 mins to fix

          Method viewTenantDetailPermissionsTab has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            private String viewTenantDetailPermissionsTab(final String id, final Model model, final String messageCode, final boolean isError, final int tab) {
          Severity: Minor
          Found in sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/controller/admin/TenantPermissionsController.java - About 35 mins to fix

            Method doBeforeSearchPage has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

              @Override
  protected void doBeforeSearchPage(final HttpServletRequest request, final SearchFilter filter) {
    String uri = "/admin/grants/{type}/{id}";
    if (request.getRequestURI().contains("excel")) {
      uri += "/excel";
            Severity: Minor
            Found in sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/controller/admin/TenantPermissionsController.java - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              @RequestMapping(value = "/{id}/changeMapVisibility", method = RequestMethod.POST)
  public String changeMapVisibility(@PathVariable final String id, @RequestParam final String newMapVisibility,
      @RequestParam final String[] selectedIds, final Model model) {
    final boolean isMapVisible = StringUtils.hasText(newMapVisibility) && "public".equals(newMapVisibility) ? true : false;
    tenantPermissionService.changeMapVisibility(selectedIds, isMapVisible);
            Severity: Minor
            Found in sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/controller/admin/TenantPermissionsController.java and 1 other location - About 50 mins to fix
            sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/controller/admin/TenantPermissionsController.java on lines 193..199

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 59.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              @RequestMapping(value = "/{id}/changeListVisibility", method = RequestMethod.POST)
  public String changeListVisibility(@PathVariable final String id, @RequestParam final String newListVisibility,
      @RequestParam final String[] selectedIds, final Model model) {
    final boolean isListVisible = StringUtils.hasText(newListVisibility) && "public".equals(newListVisibility) ? true : false;
    tenantPermissionService.changeListVisibility(selectedIds, isListVisible);
            Severity: Minor
            Found in sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/controller/admin/TenantPermissionsController.java and 1 other location - About 50 mins to fix
            sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/controller/admin/TenantPermissionsController.java on lines 185..191

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 59.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              protected void deletePermissions(final List<TenantPermission> tenantPermissions) {
    for (final TenantPermission tenantPermissionAux : tenantPermissions) {
      final TenantPermission tenantPermission = tenantPermissionService.find(tenantPermissionAux);
      if (tenantPermission != null) {
        tenantPermissionService.delete(tenantPermission);
            Severity: Minor
            Found in sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/controller/admin/TenantPermissionsController.java and 1 other location - About 30 mins to fix
            sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/converter/ApiConverter.java on lines 81..88

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 41.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status