Sign upLogin

sentilo/sentilo

View on GitHub
Star
sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/domain/Activity.java

Summary

Maintainability
D
2 days
Test Coverage

Activity has 68 methods (exceeds 20 allowed). Consider refactoring.
Open

public class Activity implements CatalogDocument, Comparable<Activity> {

  private static final long serialVersionUID = 1L;

  @JsonIgnore
Severity: Major
Found in sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/domain/Activity.java - About 1 day to fix

    File Activity.java has 340 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*
 * Sentilo
 *
 * Original version 1.4 Copyright (C) 2013 Institut Municipal d’Informàtica, Ajuntament de
 * Barcelona. Modified by Opentrends adding support for multitenant deployments and SaaS.
    Severity: Minor
    Found in sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/domain/Activity.java - About 4 hrs to fix

      Method equals has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        @Override
  public boolean equals(final Object obj) {
    if (this == obj) {
      return true;
    }
      Severity: Minor
      Found in sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/domain/Activity.java - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

              return false;
      Severity: Major
      Found in sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/domain/Activity.java - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

            return true;
        Severity: Major
        Found in sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/domain/Activity.java - About 30 mins to fix

          Identical blocks of code found in 6 locations. Consider refactoring.
          Open

            @Override
  public boolean equals(final Object obj) {
    if (this == obj) {
      return true;
    }
          Severity: Major
          Found in sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/domain/Activity.java and 5 other locations - About 1 hr to fix
          sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/domain/ActiveSubscription.java on lines 121..141
          sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/domain/DocumentFile.java on lines 258..278
          sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/domain/Performance.java on lines 111..131
          sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/domain/Sensor.java on lines 181..201
          sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/domain/Tenant.java on lines 232..252

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 106.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 18 locations. Consider refactoring.
          Open

            @Override
  public int hashCode() {
    // Hashcode return must be consistent with the equals method
    final int prime = 79;
    int result = 1;
          Severity: Major
          Found in sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/domain/Activity.java and 17 other locations - About 45 mins to fix
          sentilo-agent-alert/src/main/java/org/sentilo/agent/alert/domain/InternalAlert.java on lines 75..82
          sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/domain/ActiveSubscription.java on lines 112..119
          sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/domain/Alert.java on lines 138..145
          sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/domain/AlertRule.java on lines 113..119
          sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/domain/Application.java on lines 118..125
          sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/domain/Component.java on lines 169..176
          sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/domain/ComponentType.java on lines 110..117
          sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/domain/DocumentFile.java on lines 250..256
          sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/domain/FederationConfig.java on lines 120..127
          sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/domain/Performance.java on lines 133..140
          sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/domain/Provider.java on lines 125..132
          sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/domain/Sensor.java on lines 172..179
          sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/domain/SensorSubstate.java on lines 61..68
          sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/domain/SensorType.java on lines 97..104
          sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/domain/Tenant.java on lines 224..230
          sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/domain/User.java on lines 120..127
          sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/dto/EntityMetadataDTO.java on lines 62..69

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 53.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

            public void buildId() {
    String aux = Long.toString(timestamp);
    if (StringUtils.hasText(tenant)) {
      aux += tenant;
    }
          Severity: Minor
          Found in sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/domain/Activity.java and 1 other location - About 30 mins to fix
          sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/domain/Performance.java on lines 102..109

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 41.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status