Sign upLogin

sentilo/sentilo

View on GitHub
Star
sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/service/impl/AbstractBaseCrudServiceImpl.java

Summary

Maintainability
C
1 day
Test Coverage

AbstractBaseCrudServiceImpl has 47 methods (exceeds 20 allowed). Consider refactoring.
Open

public abstract class AbstractBaseCrudServiceImpl<T extends CatalogDocument> extends AbstractBaseServiceImpl implements CrudService<T>, ApplicationContextAware {

  protected static final Logger LOGGER = LoggerFactory.getLogger(AbstractBaseCrudServiceImpl.class);

  private ApplicationContext context;
Severity: Minor
Found in sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/service/impl/AbstractBaseCrudServiceImpl.java - About 6 hrs to fix

    File AbstractBaseCrudServiceImpl.java has 303 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*
 * Sentilo
 *
 * Original version 1.4 Copyright (C) 2013 Institut Municipal d’Informàtica, Ajuntament de
 * Barcelona. Modified by Opentrends adding support for multitenant deployments and SaaS.
    Severity: Minor
    Found in sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/service/impl/AbstractBaseCrudServiceImpl.java - About 3 hrs to fix

      Method doDelete has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        protected <V extends CatalogDocument> void doDelete(final Query query, final Class<V> resourceType) {
    if (SyncResource.class.isAssignableFrom(resourceType)) {

      final String collectionName = getMongoOps().getCollectionName(resourceType);
      final Query queryFiltered = query;
      Severity: Minor
      Found in sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/service/impl/AbstractBaseCrudServiceImpl.java - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method updateAll has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        @Override
  @Auditable(actionType = AuditingActionType.UPDATE)
  @Transactional
  public Collection<T> updateAll(final Collection<T> entities) {
      Severity: Minor
      Found in sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/service/impl/AbstractBaseCrudServiceImpl.java - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status