Sign upLogin

sentilo/sentilo

View on GitHub
Star
sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/validator/ApiValidator.java

Summary

Maintainability
C
1 day
Test Coverage

Method validateComponentsLocations has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

  private void validateComponentsLocations(final ApiValidationResults results, final ApiConverterContext context) {
    final boolean isUpdateAction = context.isUpdateAction();
    final List<? extends CatalogElement> resources = isUpdateAction ? context.getMessage().getComponents() : context.getMessage().getSensors();

    if (!CollectionUtils.isEmpty(resources)) {
Severity: Minor
Found in sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/validator/ApiValidator.java - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method validateLocationContent has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

  private void validateLocationContent(final ApiValidationResults results, final Component component) {
    if (component.getLocation() != null && !SentiloUtils.arrayIsEmpty(component.getLocation().getCoordinates())) {
      final LngLat[] coordinates = component.getLocation().getCoordinates();
      boolean valid = true;
      for (int i = 0; i < coordinates.length && valid; i++) {
Severity: Minor
Found in sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/validator/ApiValidator.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method validateSensorsAndComponents has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  public ApiValidationResults validateSensorsAndComponents(final List<Sensor> sensors, final List<Component> components,
      final boolean isUpdateAction) {
    final ApiValidationResults results = new ApiValidationResults();
    final List<SensorType> sensorTypes = sensorTypesService.findAll();
    final List<ComponentType> componentTypes = componentTypesService.findAll();
Severity: Minor
Found in sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/validator/ApiValidator.java - About 1 hr to fix

    Method validateSensorsAndComponents has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

      public ApiValidationResults validateSensorsAndComponents(final List<Sensor> sensors, final List<Component> components,
      final boolean isUpdateAction) {
    final ApiValidationResults results = new ApiValidationResults();
    final List<SensorType> sensorTypes = sensorTypesService.findAll();
    final List<ComponentType> componentTypes = componentTypesService.findAll();
    Severity: Minor
    Found in sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/validator/ApiValidator.java - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method validateTechnicalDetails has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      private void validateTechnicalDetails(final ApiValidationResults results, final TechnicalDetails technicalDetails, final String resourceId,
      final CatalogDocument resource, final String[] connectivityTypesList, final String[] energyTypesList) {
    Severity: Minor
    Found in sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/validator/ApiValidator.java - About 45 mins to fix

      Method validateTechnicalDetails has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        private void validateTechnicalDetails(final ApiValidationResults results, final TechnicalDetails technicalDetails, final String resourceId,
      final CatalogDocument resource, final String[] connectivityTypesList, final String[] energyTypesList) {
    final String resourceType = resource instanceof Component ? COMPONENT : SENSOR;
    if (technicalDetails != null) {
      final String connectivity = technicalDetails.getConnectivity();
      Severity: Minor
      Found in sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/validator/ApiValidator.java - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method validateGeodeticSystem has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        private void validateGeodeticSystem(final ApiValidationResults results, final String geodeticSystem, final String componentName,
      final Component component, final String[] geodeticList) {
      Severity: Minor
      Found in sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/validator/ApiValidator.java - About 35 mins to fix

        Method validateSensorsDataType has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          private void validateSensorsDataType(final ApiValidationResults results, final ApiConverterContext context) {
    final List<CatalogSensor> resources = context.getMessage().getSensors();

    if (!CollectionUtils.isEmpty(resources)) {
      for (final CatalogSensor resource : resources) {
        Severity: Minor
        Found in sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/validator/ApiValidator.java - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          private void validateSensorTypes(final ApiValidationResults results, final Sensor sensor, final List<SensorType> sensorTypes) {
    if (!sensorTypes.contains(new SensorType(sensor.getType()))) {
      final String errorMessage = buildErrorMessage(SENSOR, sensor.getSensorId(), "type", sensor.getType());
      results.addErrorMessage(errorMessage);
    }
        Severity: Minor
        Found in sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/validator/ApiValidator.java and 1 other location - About 40 mins to fix
        sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/validator/ApiValidator.java on lines 156..161

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          private void validateComponentTypes(final ApiValidationResults results, final Component component, final List<ComponentType> componentTypes) {
    if (!componentTypes.contains(new ComponentType(component.getComponentType()))) {
      final String errorMessage = buildErrorMessage(COMPONENT, component.getName(), "componentType", component.getComponentType());
      results.addErrorMessage(errorMessage);
    }
        Severity: Minor
        Found in sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/validator/ApiValidator.java and 1 other location - About 40 mins to fix
        sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/validator/ApiValidator.java on lines 149..154

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            if (StringUtils.hasText(geodeticSystem) && !arrayContainsValue(geodeticList, geodeticSystem)) {
      final String errorMessage = buildErrorMessage(COMPONENT, componentName, "coordinateSystem", geodeticSystem);
      results.addErrorMessage(errorMessage);
    }
        Severity: Minor
        Found in sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/validator/ApiValidator.java and 2 other locations - About 35 mins to fix
        sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/validator/ApiValidator.java on lines 170..173
        sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/validator/ApiValidator.java on lines 175..178

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 44.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

              if (StringUtils.hasText(energy) && !arrayContainsValue(energyTypesList, energy)) {
        final String errorMessage = buildErrorMessage(resourceType, resourceId, "energy", energy);
        results.addErrorMessage(errorMessage);
      }
        Severity: Minor
        Found in sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/validator/ApiValidator.java and 2 other locations - About 35 mins to fix
        sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/validator/ApiValidator.java on lines 175..178
        sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/validator/ApiValidator.java on lines 185..188

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 44.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

              if (StringUtils.hasText(connectivity) && !arrayContainsValue(connectivityTypesList, connectivity)) {
        final String errorMessage = buildErrorMessage(resourceType, resourceId, "connectivity", connectivity);
        results.addErrorMessage(errorMessage);
      }
        Severity: Minor
        Found in sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/validator/ApiValidator.java and 2 other locations - About 35 mins to fix
        sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/validator/ApiValidator.java on lines 170..173
        sentilo-catalog-web/src/main/java/org/sentilo/web/catalog/validator/ApiValidator.java on lines 185..188

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 44.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status