Sign upLogin

sentilo/sentilo

View on GitHub
Star
sentilo-platform/sentilo-platform-service/src/main/java/org/sentilo/platform/service/impl/ResourceServiceImpl.java

Summary

Maintainability
B
4 hrs
Test Coverage

File ResourceServiceImpl.java has 275 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 * Sentilo
 *
 * Original version 1.4 Copyright (C) 2013 Institut Municipal d’Informàtica, Ajuntament de
 * Barcelona. Modified by Opentrends adding support for multitenant deployments and SaaS.
Severity: Minor
Found in sentilo-platform/sentilo-platform-service/src/main/java/org/sentilo/platform/service/impl/ResourceServiceImpl.java - About 2 hrs to fix

    Method registerSensorIfNeedBe has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      @Override
  public Long registerSensorIfNeedBe(final CatalogSensor sensor, final boolean update) {
    Optional<Long> sid = sequenceUtils.getLocalSid(sensor.getProvider(), sensor.getSensor());
    boolean isNew = false;
    if (!sid.isPresent()) {
    Severity: Minor
    Found in sentilo-platform/sentilo-platform-service/src/main/java/org/sentilo/platform/service/impl/ResourceServiceImpl.java - About 1 hr to fix

      Method removeProvider has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        @Override
  public void removeProvider(final String providerId) {
    LOGGER.debug("Deleting provider {} from Redis", providerId);
    final Optional<Long> pid = sequenceUtils.getPid(providerId);
    if (pid.isPresent()) {
      Severity: Minor
      Found in sentilo-platform/sentilo-platform-service/src/main/java/org/sentilo/platform/service/impl/ResourceServiceImpl.java - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status