seregazhuk/php-headhunter-api

View on GitHub

Showing 93 of 93 total issues

Expected 1 space after IF keyword; 0 found
Open

        if(!isset($managers['items']) ) {

Expected 1 space after IF keyword; 0 found
Open

        if(!class_exists($class)) return false;

Expected 1 newline at end of file; 0 found
Open

}
Severity: Minor
Found in src/EndPoints/Suggests.php by phpcodesniffer

Expected 1 newline at end of file; 0 found
Open

}
Severity: Minor
Found in src/Traits/HasView.php by phpcodesniffer

Opening brace should be on a new line
Open

    public function tearDown() {

Expected 1 newline at end of file; 0 found
Open

}
Severity: Minor
Found in src/Api.php by phpcodesniffer

Expected 1 newline at end of file; 0 found
Open

}

Expected 1 newline at end of file; 0 found
Open

}
Severity: Minor
Found in src/EndPoints/Endpoint.php by phpcodesniffer

Expected 1 newline at end of file; 0 found
Open

}
Severity: Minor
Found in src/EndPoints/Vacancies.php by phpcodesniffer

The method it_delegates_setters_to_request_object is not named in camelCase.
Open

    public function it_delegates_setters_to_request_object()
    {
        $host = 'value';
        $this->request->shouldReceive('setHost')
            ->once()
Severity: Minor
Found in tests/EndpointContainerTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method it_returns_a_provider_instance is not named in camelCase.
Open

    public function it_returns_a_provider_instance()
    {
        $provider = $this->container->vacancies;
        $this->assertInstanceOf(Vacancies::class, $provider);
    }
Severity: Minor
Found in tests/EndpointContainerTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method it_throws_exception_when_accessing_request_setter_that_doesnt_exist is not named in camelCase.
Open

    public function it_throws_exception_when_accessing_request_setter_that_doesnt_exist()
    {
        $this->expectException(HeadHunterApiException::class);
        $this->container->setProperty('value');
    }
Severity: Minor
Found in tests/EndpointContainerTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method it_throws_exception_when_trying_to_access_wrong_provider is not named in camelCase.
Open

    public function it_throws_exception_when_trying_to_access_wrong_provider()
    {
        $this->expectException(WrongEndPointException::class);
        $this->container->getEndpoint('unknown');
    }
Severity: Minor
Found in tests/EndpointContainerTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

Severity
Category
Status
Source
Language