Sign upLogin

seregazhuk/php-pinterest-bot

View on GitHub
Star
src/Api/Providers/Auth.php

Summary

Maintainability
A
1 hr
Test Coverage

Method getRegistrationForm has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    protected function getRegistrationForm($email, $password, $name, $country, $age)
Severity: Minor
Found in src/Api/Providers/Auth.php - About 35 mins to fix

    Method fillRegistrationForm has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        protected function fillRegistrationForm($registrationForm, $password, $name, $country, $age)
    Severity: Minor
    Found in src/Api/Providers/Auth.php - About 35 mins to fix

      Method register has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function register($email, $password = null, $name = null, $country = 'GB', $age = 18)
      Severity: Minor
      Found in src/Api/Providers/Auth.php - About 35 mins to fix

        The method login has a boolean flag argument $autoLogin, which is a certain sign of a Single Responsibility Principle violation.
        Open

            public function login($username, $password, $autoLogin = true)
        Severity: Minor
        Found in src/Api/Providers/Auth.php by phpmd

        BooleanArgumentFlag

        Since: 1.4.0

        A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

        Example

        class Foo {
    public function bar($flag = true) {
    }
}

        Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

        Only one argument is allowed per line in a multi-line function call
        Open

                    $email, $password, $name, $country, $age
        Severity: Minor
        Found in src/Api/Providers/Auth.php by phpcodesniffer

        Only one argument is allowed per line in a multi-line function call
        Open

                    $email, $password, $name, $country, $age
        Severity: Minor
        Found in src/Api/Providers/Auth.php by phpcodesniffer

        Only one argument is allowed per line in a multi-line function call
        Open

                    $email, $password, $name, $country, $age
        Severity: Minor
        Found in src/Api/Providers/Auth.php by phpcodesniffer

        Only one argument is allowed per line in a multi-line function call
        Open

                    $email, $password, $name, $country, $age
        Severity: Minor
        Found in src/Api/Providers/Auth.php by phpcodesniffer

        There are no issues that match your filters.

        Category
        Status