Sign upLogin

seregazhuk/php-pinterest-bot

View on GitHub
Star
src/Api/Traits/BoardInvites.php

Summary

Maintainability
A
0 mins
Test Coverage

The method deleteInvite has a boolean flag argument $ban, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function deleteInvite($boardId, $userId, $ban = false)
Severity: Minor
Found in src/Api/Traits/BoardInvites.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Only one argument is allowed per line in a multi-line function call
Open

            UrlBuilder::RESOURCE_BOARDS_INVITES, ['board_id' => (string) $boardId], $limit
Severity: Minor
Found in src/Api/Traits/BoardInvites.php by phpcodesniffer

Only one argument is allowed per line in a multi-line function call
Open

            UrlBuilder::RESOURCE_BOARDS_INVITES, ['board_id' => (string) $boardId], $limit
Severity: Minor
Found in src/Api/Traits/BoardInvites.php by phpcodesniffer

There are no issues that match your filters.

Category
Status