src/Api/Requests/XMLRequest.php
The method checkCoupon has a boolean flag argument $markAsUsed, which is a certain sign of a Single Responsibility Principle violation. Open
Open
public function checkCoupon($coupon, $markAsUsed = true, $phone = null)- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}Source https://phpmd.org/rules/cleancode.html#booleanargumentflag
Closing parenthesis of a multi-line function call must be on a line by itself Open
Open
]);- Exclude checks
Opening parenthesis of a multi-line function call must be the last content on the line Open
Open
return $this->exec('reportNumber',- Exclude checks
Multi-line function call not indented correctly; expected 8 spaces but found 12 Open
Open
]);- Exclude checks