Sign upLogin

serge-web/serge-web

View on GitHub
Star
client/src/Helpers/handle-channel-updates.ts

Summary

Maintainability
D
2 days
Test Coverage

File handle-channel-updates.ts has 300 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { CHANNEL_CHAT, CHANNEL_COLLAB, CHAT_CHANNEL_ID, CUSTOM_MESSAGE, expiredStorage, INFO_MESSAGE, INFO_MESSAGE_CLIPPED } from 'src/config'
import {
  ChannelTypes, ChannelUI, ForceData, MessageChannel,
  MessageCustom, MessageInfoType, MessageInfoTypeClipped, PlayerMessage, PlayerMessageLog, PlayerUiChannels, PlayerUiChatChannel, Role, SetWargameMessage, TemplateBodysByKey
} from 'src/custom-types'
Severity: Minor
Found in client/src/Helpers/handle-channel-updates.ts - About 3 hrs to fix

    Function handleNonInfoMessage has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

    const handleNonInfoMessage = (data: SetWargameMessage, channel: string, message: MessageCustom, playerId: string) => {
  const sourceRole: string = message.details.from.roleId
  const logger: PlayerMessage = {
    roleId: message.details.from.roleId,
    lastMessageTitle: message.templateId,
    Severity: Minor
    Found in client/src/Helpers/handle-channel-updates.ts - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function handleNonInfoMessage has 51 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const handleNonInfoMessage = (data: SetWargameMessage, channel: string, message: MessageCustom, playerId: string) => {
  const sourceRole: string = message.details.from.roleId
  const logger: PlayerMessage = {
    roleId: message.details.from.roleId,
    lastMessageTitle: message.templateId,
    Severity: Major
    Found in client/src/Helpers/handle-channel-updates.ts - About 2 hrs to fix

      Function createOrUpdateChannelUI has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      const createOrUpdateChannelUI = (
  channel: ChannelTypes,
  forceId: string | undefined,
  selectedRole: Role['roleId'],
  isObserver: boolean,
      Severity: Minor
      Found in client/src/Helpers/handle-channel-updates.ts - About 1 hr to fix

        Function handleAllInitialChannelMessages has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export const handleAllInitialChannelMessages = (
  payload: Array<MessageInfoType | MessageCustom>,
  currentWargame: string,
  selectedForce: ForceData | undefined,
  selectedRole: Role['roleId'],
        Severity: Minor
        Found in client/src/Helpers/handle-channel-updates.ts - About 1 hr to fix

          Consider simplifying this complex logical expression.
          Open

            if ((isUmpire && isObserver) || isParticipant) {
    const { forceIcons, forceColors, forceNames } = buildForceIconsColorsNames(channel.participants, allForces)
    const isCollab = channel.channelType === CHANNEL_COLLAB
    const messages = messagesFiltered.filter(
      (message) => (message.details && message.details.channel === channel.uniqid) || (!isCollab && message.messageType === INFO_MESSAGE_CLIPPED)
          Severity: Major
          Found in client/src/Helpers/handle-channel-updates.ts - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                if (message.message?.reference) {
      // remove any existing RFI with this reference number. Note: we can't use
      // filter() array function since it produces a new array, which would
      // have a new reference, and wouldn't get returned as a parameter
      theChannel.messages.forEach((msg, idx) => {
            Severity: Major
            Found in client/src/Helpers/handle-channel-updates.ts and 1 other location - About 2 hrs to fix
            client/src/Helpers/handle-channel-updates.ts on lines 54..64

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 91.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                } else if (message.message?.Reference) {
      // remove any existing RFI with this reference number. Note: we can't use
      // filter() array function since it produces a new array, which would
      // have a new reference, and wouldn't get returned as a parameter
      theChannel.messages.forEach((msg, idx) => {
            Severity: Major
            Found in client/src/Helpers/handle-channel-updates.ts and 1 other location - About 2 hrs to fix
            client/src/Helpers/handle-channel-updates.ts on lines 44..64

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 91.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status