Sign upLogin

serp-spider/search-engine-google

View on GitHub
Star

Showing 47 of 47 total issues

Function query has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    public function query(GoogleUrlInterface $googleUrl, BrowserInterface $browser = null)
    {

        if ($googleUrl->getResultType() !== GoogleUrl::RESULT_TYPE_ALL) {
            throw new Exception(
Severity: Minor
Found in src/GoogleClient.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method parseNode has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function parseNode(GoogleDom $dom, DomNodeInterface $node)
    {
        return [
            'title' => function () use ($dom, $node) {
                return $dom
Severity: Minor
Found in src/Parser/Evaluated/Rule/Natural/Classical/ClassicalCardsResultZINbbc.php - About 1 hr to fix

    Method parseNode has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function parseNode(GoogleDom $dom, DomElement $node)
    {
        return [
            'title' => function () use ($dom, $node) {
                return $dom
    Severity: Minor
    Found in src/Parser/Evaluated/Rule/Natural/Classical/ClassicalCardsResultZ1m.php - About 1 hr to fix

      Method parseNode has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function parseNode(GoogleDom $dom, \DomElement $node)
    {

        // find the title/url
        /* @var $aTag \DOMElement */
      Severity: Minor
      Found in src/Parser/Evaluated/Rule/Natural/Classical/ClassicalResult.php - About 1 hr to fix

        Method parse has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function parse(GoogleDom $dom, \DomElement $node, IndexedResultSet $resultSet)
    {

        $item = new BaseResult(NaturalResultType::TWEETS_CAROUSEL, [
        Severity: Minor
        Found in src/Parser/Evaluated/Rule/Natural/TweetsCarouselZ1m.php - About 1 hr to fix

          Method parseNode has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function parseNode(GoogleDom $dom, DomNodeInterface $node)
    {
        return [
            'title' => function () use ($dom, $node) {
                return $dom
          Severity: Minor
          Found in src/Parser/Evaluated/Rule/Natural/Classical/ClassicalCardsResultO9g5cc.php - About 1 hr to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                public static function build(
        $scheme = null,
        $host = null,
        $path = null,
        array $query = [],
            Severity: Major
            Found in src/GoogleUrlArchive.php and 1 other location - About 1 hr to fix
            src/GoogleUrl.php on lines 37..57

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 105.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                public static function build(
        $scheme = null,
        $host = null,
        $path = null,
        array $query = [],
            Severity: Major
            Found in src/GoogleUrl.php and 1 other location - About 1 hr to fix
            src/GoogleUrlArchive.php on lines 32..52

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 105.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Method parse has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function parse(GoogleDom $dom, \DomElement $node, IndexedResultSet $resultSet)
    {
        $xpath = $dom->getXpath();
        $aTag = $xpath->query("descendant::h3[@class='r'][1]/a", $node)->item(0);
            Severity: Minor
            Found in src/Parser/Evaluated/Rule/Natural/Classical/ClassicalWithLargeVideo.php - About 1 hr to fix

              Method parse has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function parse(GoogleDom $dom, \DomElement $node, IndexedResultSet $resultSet)
    {
        $data = $this->parseNode($dom, $node);

        $resultTypes = [NaturalResultType::CLASSICAL];
              Severity: Minor
              Found in src/Parser/Evaluated/Rule/Natural/Classical/ClassicalResult.php - About 1 hr to fix

                Method getRelatedSearches has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function getRelatedSearches()
    {
        $relatedSearches = [];
        if ($this->isMobile()) {
            $items = $this->cssQuery('#botstuff div:not(#bres) a.QsZ7bb');
                Severity: Minor
                Found in src/Page/GoogleSerp.php - About 1 hr to fix

                  Method build has 8 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                          $scheme = null,
        $host = null,
        $path = null,
        array $query = [],
        $hash = null,
                  Severity: Major
                  Found in src/GoogleUrlArchive.php - About 1 hr to fix

                    Method build has 8 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                            $scheme = null,
        $host = null,
        $path = null,
        array $query = [],
        $hash = null,
                    Severity: Major
                    Found in src/GoogleUrl.php - About 1 hr to fix

                      Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                              $host = 'www.google.com',
        $path = '/search',
        $scheme = 'https',
        array $query = [],
        $hash = '',
                      Severity: Major
                      Found in src/GoogleUrl.php - About 1 hr to fix

                        Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                                $host = 'google.com',
        $path = '/search',
        $scheme = 'https',
        array $query = [],
        $hash = '',
                        Severity: Major
                        Found in src/GoogleUrlArchive.php - About 1 hr to fix

                          Function parse has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public function parse(GoogleDom $googleDOM, \DomElement $node, IndexedResultSet $resultSet)
    {
        $item = [
            'title' => function () use ($googleDOM, $node) {
                $aTag = $googleDOM->getXpath()->query('descendant::h3/a[2]', $node)->item(0);
                          Severity: Minor
                          Found in src/Parser/Evaluated/Rule/Adwords/AdwordsItem.php - About 45 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                              public function __construct(
        $host = 'www.google.com',
        $path = '/search',
        $scheme = 'https',
        array $query = [],
                          Severity: Minor
                          Found in src/GoogleUrl.php and 1 other location - About 40 mins to fix
                          src/GoogleUrlArchive.php on lines 19..30

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 93.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                              public function __construct(
        $host = 'google.com',
        $path = '/search',
        $scheme = 'https',
        array $query = [],
                          Severity: Minor
                          Found in src/GoogleUrlArchive.php and 1 other location - About 40 mins to fix
                          src/GoogleUrl.php on lines 24..35

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 93.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Avoid too many return statements within this method.
                          Open

                                  return new BaseResult(NaturalResultType::IMAGE_GROUP_IMAGE, $data);
                          Severity: Major
                          Found in src/Parser/Evaluated/Rule/Natural/ImageGroupCarousel.php - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                                return null;
                            Severity: Major
                            Found in src/Parser/Evaluated/Rule/Adwords/AdwordsItem.php - About 30 mins to fix
                              Severity
                              Category
                              Status
                              Source
                              Language