serp-spider/search-engine-google

View on GitHub
src/GoogleUrlArchive.php

Summary

Maintainability
A
3 hrs
Test Coverage

Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
Open

        $host = 'google.com',
        $path = '/search',
        $scheme = 'https',
        array $query = [],
        $hash = '',
Severity: Major
Found in src/GoogleUrlArchive.php - About 1 hr to fix

    Method build has 8 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            $scheme = null,
            $host = null,
            $path = null,
            array $query = [],
            $hash = null,
    Severity: Major
    Found in src/GoogleUrlArchive.php - About 1 hr to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          public static function build(
              $scheme = null,
              $host = null,
              $path = null,
              array $query = [],
      Severity: Major
      Found in src/GoogleUrlArchive.php and 1 other location - About 1 hr to fix
      src/GoogleUrl.php on lines 37..57

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 105.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public function __construct(
              $host = 'google.com',
              $path = '/search',
              $scheme = 'https',
              array $query = [],
      Severity: Minor
      Found in src/GoogleUrlArchive.php and 1 other location - About 40 mins to fix
      src/GoogleUrl.php on lines 24..35

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 93.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status