Sign upLogin

set-theory/cartesian-product

View on GitHub
Star

Showing 6 of 6 total issues

Function diagonal has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
Open

export default function* diagonal(A, B) {
    const itA = iter(A);
    const itB = iter(B);
    const _A = deque();
    const _B = deque();
Severity: Minor
Found in src/diagonal.js - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            if (_b.done) {
                if (_B.length === 0) return;
                do {
                    _A.append(_a.value);
                    _A.popleft();
Severity: Major
Found in src/diagonal.js and 1 other location - About 4 hrs to fix
src/diagonal.js on lines 54..64

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 118.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        } else {
            if (_A.length === 0) return;
            do {
                _B.append(_b.value);
                _B.popleft();
Severity: Major
Found in src/diagonal.js and 1 other location - About 4 hrs to fix
src/diagonal.js on lines 37..47

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 118.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function diagonal has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export default function* diagonal(A, B) {
    const itA = iter(A);
    const itB = iter(B);
    const _A = deque();
    const _B = deque();
Severity: Minor
Found in src/diagonal.js - About 1 hr to fix

    Avoid deeply nested control flow statements.
    Open

                        for (let i = 0; i < n; ++i) yield [_A.get(i), _B.get(n - i - 1)];
    Severity: Major
    Found in src/diagonal.js - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                      for (let i = 0; i < n; ++i) yield [_A.get(i), _B.get(n - i - 1)];
      Severity: Major
      Found in src/diagonal.js - About 45 mins to fix
        Severity
        Category
        Status
        Source
        Language