Sign upLogin

set-theory/cartesian-product

View on GitHub
Star

Showing 4 of 6 total issues

Function diagonal has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
Open

export default function* diagonal(A, B) {
    const itA = iter(A);
    const itB = iter(B);
    const _A = deque();
    const _B = deque();
Severity: Minor
Found in src/diagonal.js - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function diagonal has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export default function* diagonal(A, B) {
    const itA = iter(A);
    const itB = iter(B);
    const _A = deque();
    const _B = deque();
Severity: Minor
Found in src/diagonal.js - About 1 hr to fix

    Avoid deeply nested control flow statements.
    Open

                        for (let i = 0; i < n; ++i) yield [_A.get(i), _B.get(n - i - 1)];
    Severity: Major
    Found in src/diagonal.js - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                      for (let i = 0; i < n; ++i) yield [_A.get(i), _B.get(n - i - 1)];
      Severity: Major
      Found in src/diagonal.js - About 45 mins to fix
        Severity
        Category
        Status
        Source
        Language