Sign upLogin

setokinto/slack-shogi

View on GitHub
Star
app/modules/shogi_input.py

Summary

Maintainability
B
4 hrs
Test Coverage

Function move has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def move(self, from_x, from_y, to_x, to_y, promote):
Severity: Minor
Found in app/modules/shogi_input.py - About 35 mins to fix

    Function basic_move has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def basic_move(channel_id, from_x, from_y, to_x, to_y, promote):
    Severity: Minor
    Found in app/modules/shogi_input.py - About 35 mins to fix

      Function movable has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def movable(self, from_x, from_y, to_x, to_y, promote):
      Severity: Minor
      Found in app/modules/shogi_input.py - About 35 mins to fix

        Function koma_is_movable has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def koma_is_movable(channel_id, user_id, position, koma, sub_position, promote):
        Severity: Minor
        Found in app/modules/shogi_input.py - About 35 mins to fix

          Function move has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              def move(movement_str, channel_id, user_id):
        shogi = ShogiInput.manager.get_shogi(channel_id)
        if not shogi.validate(shogi, user_id):
            raise UserDifferentException()
          Severity: Minor
          Found in app/modules/shogi_input.py - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  self.second_user = ShogiUser(users[1]["id"], users[1]["name"])
          Severity: Minor
          Found in app/modules/shogi_input.py and 1 other location - About 50 mins to fix
          app/modules/shogi_input.py on lines 162..162

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 36.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  self.first_user = ShogiUser(users[0]["id"], users[0]["name"])
          Severity: Minor
          Found in app/modules/shogi_input.py and 1 other location - About 50 mins to fix
          app/modules/shogi_input.py on lines 163..163

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 36.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status