Sign upLogin

setokinto/slack-shogi

View on GitHub
Star

Showing 76 of 76 total issues

Avoid too many return statements within this function.
Open

                    return False
Severity: Major
Found in app/modules/shogi.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

            return False
    Severity: Major
    Found in app/modules/shogi.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                      return False
      Severity: Major
      Found in app/modules/shogi.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return True
        Severity: Major
        Found in app/modules/shogi.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                          return False
          Severity: Major
          Found in app/modules/parse_input.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                                return False
            Severity: Major
            Found in app/modules/shogi.py - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                          return False
              Severity: Major
              Found in app/modules/parse_input.py - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                        return (from_x, from_y, to_x, to_y, promote, koma)
                Severity: Major
                Found in app/modules/parse_input.py - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                                          return True
                  Severity: Major
                  Found in app/modules/shogi.py - About 30 mins to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                                if from_koma.is_first():
                if not (0 <= from_y <= 2 or 0 <= to_y <= 2):
                    return False
                    Severity: Minor
                    Found in app/modules/shogi.py and 1 other location - About 30 mins to fix
                    app/modules/shogi.py on lines 227..232

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 32.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Avoid too many return statements within this function.
                    Open

                            return False
                    Severity: Major
                    Found in app/modules/shogi.py - About 30 mins to fix

                      Function find_koma has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                          def find_koma(self, koma):
        koma_positions = []
        for y in range(len(self.board)):
            for x in range(len(self.board[y])):
                if self.board[y][x] == koma:
                      Severity: Minor
                      Found in app/modules/shogi.py - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function validate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                          def validate(self, shogi, user_id):
        if shogi.first:
            if not shogi.first_user.id == user_id:
                return False
        else:
                      Severity: Minor
                      Found in app/validator.py - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function move has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                          def move(self, from_x, from_y, to_x, to_y, promote):
        koma = self.board[from_y][from_x]
        koma_for_komadai = self.board[to_y][to_x]
        if koma_for_komadai is not Koma.empty:
            koma_for_komadai = koma_for_komadai.unpromote().go_enemy()
                      Severity: Minor
                      Found in app/modules/shogi.py - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function move has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                          def move(movement_str, channel_id, user_id):
        shogi = ShogiInput.manager.get_shogi(channel_id)
        if not shogi.validate(shogi, user_id):
            raise UserDifferentException()
                      Severity: Minor
                      Found in app/modules/shogi_input.py - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function drop has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                          def drop(self, koma, to_x, to_y):
        if self.first:
            self.first_tegoma.remove(koma)
        else:
            self.second_tegoma.remove(koma)
                      Severity: Minor
                      Found in app/modules/shogi.py - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Severity
                      Category
                      Status
                      Source
                      Language