Sign upLogin

settermjd/podcast-site

View on GitHub
Star

Showing 20 of 20 total issues

File MainPage.xaml.cs has 444 lines of code (exceeds 250 allowed). Consider refactoring.
Open

using System;
using System.Collections.Generic;
using System.Linq;
using System.Net;
using System.Windows;
Severity: Minor
Found in public/silverlight/MainPage.xaml.cs - About 6 hrs to fix

    Class MainPage has 40 methods (exceeds 20 allowed). Consider refactoring.
    Open

        [ScriptableType]
    public partial class MainPage : UserControl
    {
        System.Windows.Threading.DispatcherTimer _timer;
    Severity: Minor
    Found in public/silverlight/MainPage.xaml.cs - About 5 hrs to fix

      Method setUp has 99 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function setUp()
    {
        $episode001Content = <<<EOF
---
publish_date: 13.07.2015
      Severity: Major
      Found in tests/unit/Iterator/EpisodeFilterIteratorTest.php - About 3 hrs to fix

        Method setUp has 56 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function setUp()
    {
        $content = <<<EOF
### Synopsis
        Severity: Major
        Found in tests/unit/Feed/iTunesFeedCreatorTest.php - About 2 hrs to fix

          Method testAdapterCanProperlyBuildEpisodeObject has 45 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function testAdapterCanProperlyBuildEpisodeObject()
    {
        $this->markTestIncomplete();
        $filePath = dirname(__FILE__) . '/../../../_data/posts';
        $episodeLister = EpisodeLister::factory([
          Severity: Minor
          Found in tests/unit/Episodes/Adapter/EpisodeListerFilesystemTest.php - About 1 hr to fix

            Method testAdapterCanProperlyHydrateEpisodeObject has 45 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function testAdapterCanProperlyHydrateEpisodeObject()
    {
        $this->markTestSkipped("Need to revisit this");

        $filePath = dirname(__FILE__) . '/../../../_data/posts';
            Severity: Minor
            Found in tests/unit/Episodes/Adapter/EpisodeListerFilesystemTest.php - About 1 hr to fix

              Method testCanRenderGoogleAnalytics has 45 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function testCanRenderGoogleAnalytics()
    {
        $route = $this->getMockBuilder(Route::class)
            ->disableOriginalConstructor()
            ->getMock();
              Severity: Minor
              Found in tests/unit/Middleware/GoogleAnalyticsTest.php - About 1 hr to fix

                Method generateFeed has 41 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function generateFeed(Show $show, $episodeList = [])
    {
        $feed = new ezcFeed('rss2');

        // Setup the core show information
                Severity: Minor
                Found in src/PodcastSite/Feed/iTunesFeedCreator.php - About 1 hr to fix

                  Method testCanSetAndRetrieveShowProperties has 39 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function testCanSetAndRetrieveShowProperties()
    {
        $options = [
            'url' => 'http://freethegeek.fm/',
            'episodePrefix' => 'episodes/',
                  Severity: Minor
                  Found in tests/unit/Entity/ShowTest.php - About 1 hr to fix

                    Method media_CurrentStateChanged has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                            void media_CurrentStateChanged(object sender, RoutedEventArgs e) {

            WriteDebug("state:" + media.CurrentState.ToString());

            switch (media.CurrentState)
                    Severity: Minor
                    Found in public/silverlight/MainPage.xaml.cs - About 1 hr to fix

                      Method testCanSetAndRetrieveUserProperties has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function testCanSetAndRetrieveUserProperties()
    {
        $options = [
            'fileSize' => '49099054',
            'fileType' => 'audio/x-mp3',
                      Severity: Minor
                      Found in tests/unit/Entity/EpisodeTest.php - About 1 hr to fix

                        Method testAnalyticsCodeIsNotRenderedOnItunesRoute has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function testAnalyticsCodeIsNotRenderedOnItunesRoute()
    {
        $route = $this->getMockBuilder(Route::class)
            ->disableOriginalConstructor()
            ->getMock();
                        Severity: Minor
                        Found in tests/unit/Middleware/GoogleAnalyticsTest.php - About 1 hr to fix

                          Function __construct has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public function __construct($options = [])
    {
        if (!empty($options)) {
            $memberVariables = get_class_vars(__CLASS__);
            foreach ($options as $key => $value) {
                          Severity: Minor
                          Found in src/PodcastSite/Entity/Show.php - About 45 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function __c3_factory has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                          Open

                              function __c3_factory($filename)
    {
        $phpCoverage = is_readable($filename)
            ? unserialize(file_get_contents($filename))
            : new PHP_CodeCoverage();
                          Severity: Minor
                          Found in c3.php - About 45 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                              public function testCanFilterUpcomingEpisodes()
    {
        /** @var vfsStreamDirectory $directory */
        vfsStream::setup('root', null, $this->structure);
                          Severity: Minor
                          Found in tests/unit/Iterator/EpisodeFilterIteratorTest.php and 1 other location - About 35 mins to fix
                          tests/unit/Iterator/EpisodeFilterIteratorTest.php on lines 188..200

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 92.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                              public function testCanGetAllPastEpisodes()
    {
        /** @var vfsStreamDirectory $directory */
        vfsStream::setup('root', null, $this->structure);
                          Severity: Minor
                          Found in tests/unit/Iterator/EpisodeFilterIteratorTest.php and 1 other location - About 35 mins to fix
                          tests/unit/Iterator/EpisodeFilterIteratorTest.php on lines 151..166

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 92.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Function __c3_build_html_report has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                          Open

                              function __c3_build_html_report(PHP_CodeCoverage $codeCoverage, $path)
    {
        $writer = new PHP_CodeCoverage_Report_HTML();
        $writer->process($codeCoverage, $path . 'html');
                          Severity: Minor
                          Found in c3.php - About 35 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function __construct has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public function __construct($options = [])
    {
        if (!empty($options)) {
            $memberVariables = get_class_vars(__CLASS__);
            foreach ($options as $key => $value) {
                          Severity: Minor
                          Found in src/PodcastSite/Entity/Episode.php - About 35 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                  [ScriptableMember]
        public void pauseMedia() {
            WriteDebug("method:pause " + media.CurrentState);

            _isEnded = false;
                          Severity: Minor
                          Found in public/silverlight/MainPage.xaml.cs and 1 other location - About 35 mins to fix
                          public/silverlight/MainPage.xaml.cs on lines 398..408

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 63.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                  [ScriptableMember]
        public void stopMedia() {
            WriteDebug("method:stop " + media.CurrentState);

            _isEnded = true;
                          Severity: Minor
                          Found in public/silverlight/MainPage.xaml.cs and 1 other location - About 35 mins to fix
                          public/silverlight/MainPage.xaml.cs on lines 373..383

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 63.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Severity
                          Category
                          Status
                          Source
                          Language