sfcod/jobqueue

View on GitHub

Showing 17 of 17 total issues

JobContract has 24 functions (exceeds 20 allowed). Consider refactoring.
Open

class JobContract implements JobContractInterface
{
    use InteractWithTimeTrait;

    /**
Severity: Minor
Found in Job/JobContract.php - About 2 hrs to fix

    MongoQueue has 24 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class MongoQueue extends Queue
    {
        /**
         * Job resolver
         *
    Severity: Minor
    Found in Queue/MongoQueue.php - About 2 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      <?php
      
      namespace SfCod\QueueBundle\Event;
      
      use Exception;
      Severity: Major
      Found in Event/JobFailedEvent.php and 1 other location - About 1 hr to fix
      Event/JobExceptionOccurredEvent.php on lines 1..77

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 107.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      <?php
      
      namespace SfCod\QueueBundle\Event;
      
      use Exception;
      Severity: Major
      Found in Event/JobExceptionOccurredEvent.php and 1 other location - About 1 hr to fix
      Event/JobFailedEvent.php on lines 1..77

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 107.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method addConnections has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function addConnections(ArrayNodeDefinition $rootNode)
          {
              $rootNode
                  ->children()
                      ->arrayNode('namespaces')
      Severity: Minor
      Found in DependencyInjection/QueueConfiguration.php - About 1 hr to fix

        Function execute has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            public function execute(InputInterface $input, OutputInterface $output)
            {
                $io = new SymfonyStyle($input, $output);
        
                $jobsCount = 0;
        Severity: Minor
        Found in Command/RetryCommand.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                JobResolverInterface $resolver,
                MongoDriver $mongo,
                string $collection,
                string $queue = 'default',
                int $expire = 60,
        Severity: Minor
        Found in Queue/MongoQueue.php - About 45 mins to fix

          Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  JobResolverInterface $resolver,
                  RedisDriver $redis,
                  string $collection = 'queue_jobs',
                  string $queue = 'default',
                  int $expire = 60,
          Severity: Minor
          Found in Queue/RedisQueue.php - About 45 mins to fix

            Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    int $delay = 0,
                    int $memory = 128,
                    int $timeout = 60,
                    int $sleep = 3,
                    int $maxTries = 0,
            Severity: Minor
            Found in Worker/Options.php - About 45 mins to fix

              Method later has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public function later($delay, string $job, array $data = [], string $queue = 'default', string $connection = 'default');
              Severity: Minor
              Found in Base/JobQueueInterface.php - About 35 mins to fix

                Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    public function __construct(QueueManager $queueManager,
                                                JobProcess $process,
                                                FailedJobProviderInterface $failer,
                                                ExceptionHandlerInterface $exceptions,
                                                EventDispatcherInterface $dispatcher)
                Severity: Minor
                Found in Worker/Worker.php - About 35 mins to fix

                  Method laterUnique has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      public function laterUnique($delay, string $job, array $data = [], string $queue = 'default', string $connection = 'default');
                  Severity: Minor
                  Found in Base/JobQueueInterface.php - About 35 mins to fix

                    Method later has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        public function later($delay, string $job, array $data = [], string $queue = 'default', string $connection = 'default')
                    Severity: Minor
                    Found in Service/JobQueue.php - About 35 mins to fix

                      Method buildJob has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          private function buildJob(string $id, string $queue, int $attempts, array $payload, ?int $reservedAt = null): Job
                      Severity: Minor
                      Found in Queue/RedisQueue.php - About 35 mins to fix

                        Method laterUnique has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            public function laterUnique($delay, string $job, array $data = [], string $queue = 'default', string $connection = 'default')
                        Severity: Minor
                        Found in Service/JobQueue.php - About 35 mins to fix

                          Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                                  string $scriptName,
                                  string $binPath,
                                  string $environment = 'prod',
                                  string $binary = 'php',
                                  string $binaryArgs = '')
                          Severity: Minor
                          Found in Service/JobProcess.php - About 35 mins to fix

                            Function grabJobs has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                            Open

                                private function grabJobs(array $config, ContainerBuilder $container): array
                                {
                                    $jobs = [];
                                    foreach ($config['namespaces'] as $key => $namespace) {
                                        $alias = $container->getParameter('kernel.project_dir') . '/../' . str_replace('\\', DIRECTORY_SEPARATOR, trim($namespace, '\\'));
                            Severity: Minor
                            Found in DependencyInjection/QueueExtension.php - About 25 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Severity
                            Category
                            Status
                            Source
                            Language