Sign upLogin

sgammon/GUST

View on GitHub
Star
java/gust/backend/driver/spanner/SpannerMutationSerializer.java

Summary

Maintainability
B
4 hrs
Test Coverage

Method bindValueTyped has a Cognitive Complexity of 77 (exceeds 50 allowed). Consider refactoring.
Open

    @SuppressWarnings("unchecked")
    <Primitive> void bindValueTyped(@Nonnull Descriptors.FieldDescriptor field,
                                    @Nonnull ValueBinder<Primitive> valueBinder,
                                    @Nonnull Type columnType,
                                    @Nonnull Object rawValue,
Severity: Minor
Found in java/gust/backend/driver/spanner/SpannerMutationSerializer.java - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Refactor this method to reduce its Cognitive Complexity from 76 to the 15 allowed.
Open

    <Primitive> void bindValueTyped(@Nonnull Descriptors.FieldDescriptor field,
Severity: Critical
Found in java/gust/backend/driver/spanner/SpannerMutationSerializer.java by sonar-java

Cognitive Complexity is a measure of how hard the control flow of a method is to understand. Methods with high Cognitive Complexity will be difficult to maintain.

See

Refactor this method to reduce its Cognitive Complexity from 20 to the 15 allowed.
Open

    void collapseColumnField(@Nonnull Model instance,
Severity: Critical
Found in java/gust/backend/driver/spanner/SpannerMutationSerializer.java by sonar-java

Cognitive Complexity is a measure of how hard the control flow of a method is to understand. Methods with high Cognitive Complexity will be difficult to maintain.

See

Add a default case to this switch.
Open

        switch (innerType.getCode()) {
Severity: Critical
Found in java/gust/backend/driver/spanner/SpannerMutationSerializer.java by sonar-java

The requirement for a final default clause is defensive programming. The clause should either take appropriate action, or contain a suitable comment as to why no action is taken.

Noncompliant Code Example

switch (param) {  //missing default clause
  case 0:
    doSomething();
    break;
  case 1:
    doSomethingElse();
    break;
}

switch (param) {
  default: // default clause should be the last one
    error();
    break;
  case 0:
    doSomething();
    break;
  case 1:
    doSomethingElse();
    break;
}

Compliant Solution

switch (param) {
  case 0:
    doSomething();
    break;
  case 1:
    doSomethingElse();
    break;
  default:
    error();
    break;
}

Exceptions

If the switch parameter is an Enum and if all the constants of this enum are used in the case statements, then no default clause is expected.

Example:

public enum Day {
    SUNDAY, MONDAY
}
...
switch(day) {
  case SUNDAY:
    doSomething();
    break;
  case MONDAY:
    doSomethingElse();
    break;
}

See

There are no issues that match your filters.

Category
Status