Sign upLogin

sgammon/GUST

View on GitHub
Star
tools/merge_test_results.py

Summary

Maintainability
A
0 mins
Test Coverage

Cyclomatic complexity is too high in function merge_reports. (17)
Wontfix

def merge_reports(reports, out):

    """Parses each JUnit result and merges it into one."""

    tests = 0
Severity: Minor
Found in tools/merge_test_results.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Avoid deeply nested control flow statements.
Wontfix

                        if suite_name in suites_by_name:
                            suites_by_name[suite_name].add_testcase(case)
                        else:
                            merged_suites.append(suite)
                            suites_by_name[suite_name] = suite
Severity: Major
Found in tools/merge_test_results.py - About 45 mins to fix

Avoid deeply nested control flow statements.
Wontfix

                        if suite_name == case_name:
                            # splice in a better suite & case name, if needed
                            segments = []
                            subject = path.split(report)[0]
Severity: Major
Found in tools/merge_test_results.py - About 45 mins to fix

Avoid deeply nested control flow statements.
Wontfix

                        if passed:
                            passed_tests += 1
                        else:
                            failed_tests += 1
Severity: Major
Found in tools/merge_test_results.py - About 45 mins to fix

Refactor this function to reduce its Cognitive Complexity from 37 to the 15 allowed.
Open

def merge_reports(reports, out):
Severity: Critical
Found in tools/merge_test_results.py by sonar-python

Cognitive Complexity is a measure of how hard the control flow of a function is to understand. Functions with high Cognitive Complexity will be difficult to maintain.

See

Line too long (104 > 79 characters)
Open

                                if segment == "tests" or segment == "javatests" or segment == "jstests":
Severity: Minor
Found in tools/merge_test_results.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Line too long (112 > 79 characters)
Open

        logger.error("Please provide the output file as the first argument, if you want to merge test results.")
Severity: Minor
Found in tools/merge_test_results.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Line too long (84 > 79 characters)
Open

                        line = ("- Test result '%s:%s': " % (suite_name, case_name))
Severity: Minor
Found in tools/merge_test_results.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Line too long (81 > 79 characters)
Open

                            # walk the directory tree until we hit the test base,
Severity: Minor
Found in tools/merge_test_results.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Line too long (108 > 79 characters)
Open

                logger.error("FATAL ERROR: Failed to parse report at path '%s'. Error: '%s'." % (report, e))
Severity: Minor
Found in tools/merge_test_results.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Line too long (84 > 79 characters)
Open

        logger.info("Merged %s tests across %s suites (%s passed, %s failed)..." % (
Severity: Minor
Found in tools/merge_test_results.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Multiple statements on one line (colon)
Open

if __name__ == "__main__": main()
Severity: Minor
Found in tools/merge_test_results.py by pep8

Compound statements (on the same line) are generally discouraged.

While sometimes it's okay to put an if/for/while with a small body
on the same line, never do this for multi-clause statements.
Also avoid folding such long lines!

Always use a def statement instead of an assignment statement that
binds a lambda expression directly to a name.

Okay: if foo == 'blah':\n    do_blah_thing()
Okay: do_one()
Okay: do_two()
Okay: do_three()

E701: if foo == 'blah': do_blah_thing()
E701: for x in lst: total += x
E701: while t < 10: t = delay()
E701: if foo == 'blah': do_blah_thing()
E701: else: do_non_blah_thing()
E701: try: something()
E701: finally: cleanup()
E701: if foo == 'blah': one(); two(); three()
E702: do_one(); do_two(); do_three()
E703: do_four();  # useless semicolon
E704: def f(x): return 2*x
E731: f = lambda x: 2*x

There are no issues that match your filters.

Category
Status