Sign upLogin

sghill/grunt-jenkins

View on GitHub
Star

Showing 16 of 16 total issues

Function JenkinsServer has 224 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function JenkinsServer(serverUrl, defaultOptions, fileSystem, grunt, jobUrlResolutionStrategy) {

  function verboseLogRequest(options) {
    var method = options.method || 'GET';
    grunt.verbose.writeln([method, options.url].join(' '));
Severity: Major
Found in tasks/jenkinsServer.js - About 1 day to fix

    Function exports has 164 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = function(grunt) {

  grunt.config.requires('jenkins.serverAddress');
  var pipelineDirectory = grunt.config('jenkins.pipelineDirectory') || 'pipeline';
  var serverAddress = grunt.config('jenkins.serverAddress');
    Severity: Major
    Found in tasks/jenkins.js - About 6 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        grunt.registerTask('jenkins-list-plugins', 'list all enabled Jenkins plugins', function() {
    var done = this.async();
    server.fetchEnabledPlugins().
      then(function(plugins) {
        _.each(plugins, function(p) {
      Severity: Major
      Found in tasks/jenkins.js and 1 other location - About 4 hrs to fix
      tasks/jenkins.js on lines 159..170

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 130.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        grunt.registerTask('jenkins-list-jobs', 'list all found Jenkins jobs', function() {
    var done = this.async();
    server.fetchJobs().
      then(function(jobs) {
        _.each(jobs, function(j) {
      Severity: Major
      Found in tasks/jenkins.js and 1 other location - About 4 hrs to fix
      tasks/jenkins.js on lines 172..183

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 130.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function FileSystem has 96 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function FileSystem(pipelineDirectory, grunt) {

  this.pipelineDirectory = pipelineDirectory;

  this.readFile = function(fileAndJob) {
      Severity: Major
      Found in tasks/fileSystem.js - About 3 hrs to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            request(options, function(e, r, b) {
      verboseLogRequest(options);
      verboseLogResponse(r);
      if (hasError(e, r) || authenticationFailed(r)) {
        return deferred.reject(e);
        Severity: Major
        Found in tasks/jenkinsServer.js and 1 other location - About 2 hrs to fix
        tasks/jenkinsServer.js on lines 189..196

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 80.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            request(options, function(e, r, b) {
      verboseLogRequest(options);
      verboseLogResponse(r);
      if (hasError(e, r) || authenticationFailed(r)) {
        return deferred.reject(e);
        Severity: Major
        Found in tasks/jenkinsServer.js and 1 other location - About 2 hrs to fix
        tasks/jenkinsServer.js on lines 209..216

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 80.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function compareToJobsOnDisk has 48 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          function compareToJobsOnDisk(serverJobsAndConfigurations) {
    var deferred = q.defer();
    fileSystem.loadJobs().
      then(function(jobNames) {
        var serverJobNames = _.pluck(serverJobsAndConfigurations, 'name');
        Severity: Minor
        Found in tasks/jenkins.js - About 1 hr to fix

          Function exports has 45 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          module.exports = function(grunt) {

  // Project configuration.
  grunt.initConfig({
    jshint: {
          Severity: Minor
          Found in Gruntfile.js - About 1 hr to fix

            Function JenkinsServer has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

            function JenkinsServer(serverUrl, defaultOptions, fileSystem, grunt, jobUrlResolutionStrategy) {

  function verboseLogRequest(options) {
    var method = options.method || 'GET';
    grunt.verbose.writeln([method, options.url].join(' '));
            Severity: Minor
            Found in tasks/jenkinsServer.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function fetchJobConfigurations has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              this.fetchJobConfigurations = function(jobs) {
    var deferred = q.defer();
    var promises = _.map(jobs, function(j) {
      var d = q.defer(),
        options = _.extend(defaultOptions, {
            Severity: Minor
            Found in tasks/jenkinsServer.js - About 1 hr to fix

              Function fetchJobs has 29 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                this.fetchJobs = function() {
    var deferred = q.defer(),
      options = _.extend(defaultOptions, {
        url: [serverUrl, 'api', 'json'].join('/')
      });
              Severity: Minor
              Found in tasks/jenkinsServer.js - About 1 hr to fix

                Function saveJobsToPipelineDirectory has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  this.saveJobsToPipelineDirectory = function(jobs) {
    var deferred = q.defer();
    var fileWritingPromises = _.map(jobs, function(j, index) {
      var d = q.defer();
      ensureDirectoriesExist([pipelineDirectory, j.name]);
                Severity: Minor
                Found in tasks/fileSystem.js - About 1 hr to fix

                  Function AuthenticationProvider has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  function AuthenticationProvider(grunt, netrcFactory) {
  var username = grunt.config('jenkins.username'),
    password = grunt.config('jenkins.password'),
    netrcLocation = grunt.config('jenkins.netrcLocation'),
    netrcMachine = grunt.config('jenkins.netrcMachine');
                  Severity: Minor
                  Found in tasks/authenticationProvider.js - About 1 hr to fix

                    Function JenkinsServer has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                    function JenkinsServer(serverUrl, defaultOptions, fileSystem, grunt, jobUrlResolutionStrategy) {
                    Severity: Minor
                    Found in tasks/jenkinsServer.js - About 35 mins to fix

                      Function AuthenticationProvider has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                      Open

                      function AuthenticationProvider(grunt, netrcFactory) {
  var username = grunt.config('jenkins.username'),
    password = grunt.config('jenkins.password'),
    netrcLocation = grunt.config('jenkins.netrcLocation'),
    netrcMachine = grunt.config('jenkins.netrcMachine');
                      Severity: Minor
                      Found in tasks/authenticationProvider.js - About 35 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Severity
                      Category
                      Status
                      Source
                      Language