sgmap/boussole

View on GitHub
lib/tasks/data/add_response_time.rake

Summary

Maintainability
Test Coverage

Avoid using update_attribute because it skips validations.
Open

      record.update_attribute(:response_time_upper_bound, 7) if record.response_time_upper_bound.to_i.zero?

This cop checks for the use of methods which skip validations which are listed in http://guides.rubyonrails.org/active_record_validations.html#skipping-validations

Example:

# bad
Article.first.decrement!(:view_count)
DiscussionBoard.decrement_counter(:post_count, 5)
Article.first.increment!(:view_count)
DiscussionBoard.increment_counter(:post_count, 5)
person.toggle :active
product.touch
Billing.update_all("category = 'authorized', author = 'David'")
user.update_attribute(website: 'example.com')
user.update_columns(last_request_at: Time.current)
Post.update_counters 5, comment_count: -1, action_count: 1

# good
user.update_attributes(website: 'example.com')
FileUtils.touch('file')

Unnecessary utf-8 encoding comment.
Open

# encoding: utf-8

There are no issues that match your filters.

Category
Status