Sign upLogin

sgmap/pix

View on GitHub
Star

Showing 199 of 199 total issues

Avoid too many return statements within this function.
Open

    return AnswerStatus.KO;
Severity: Major
Found in api/lib/domain/services/solution-service-qroc.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

        return AnswerStatus.KO;
    Severity: Major
    Found in api/lib/domain/services/solution-service-qroc.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          return bestAnswerSoFar.t3Ratio <= 0.25 ? bestAnswerSoFar : null;
      Severity: Major
      Found in api/lib/domain/services/solution-service-qrocm-dep.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return _.includes(bestAnswerSoFar.adminAnswers, bestAnswerSoFar.userAnswer) ? bestAnswerSoFar : null;
        Severity: Major
        Found in api/lib/domain/services/solution-service-qrocm-dep.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                return pretreatedSolution;
          Severity: Major
          Found in api/lib/domain/services/solution-service-qroc.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                return AnswerStatus.KO;
            Severity: Major
            Found in api/lib/domain/services/solution-service-qroc.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                    return AnswerStatus.OK;
              Severity: Major
              Found in api/lib/domain/services/solution-service-qroc.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                      return TIMEDOUT;
                Severity: Major
                Found in api/lib/interfaces/serializer/json-api/AnswerStatusJsonApiAdapter.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                        return UNIMPLEMENTED;
                  Severity: Major
                  Found in api/lib/interfaces/serializer/json-api/AnswerStatusJsonApiAdapter.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                          return t1(pretreatedSolution);
                    Severity: Major
                    Found in api/lib/domain/services/solution-service-qroc.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                          return AnswerStatus.KO;
                      Severity: Major
                      Found in api/lib/domain/services/solution-service-qroc.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                return pretreatedSolution;
                        Severity: Major
                        Found in api/lib/domain/services/solution-service-qrocm-dep.js - About 30 mins to fix

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                          module.exports = Bookshelf.model('Skill', {
  tableName: 'skills',

  assessment() {
    return this.belongsTo('Assessment');
                          Severity: Minor
                          Found in api/lib/infrastructure/data/skill.js and 1 other location - About 30 mins to fix
                          api/lib/infrastructure/data/feedback.js on lines 5..13

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 45.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                          module.exports = Bookshelf.model('Feedback', {

  tableName: 'feedbacks',

  assessment() {
                          Severity: Minor
                          Found in api/lib/infrastructure/data/feedback.js and 1 other location - About 30 mins to fix
                          api/lib/infrastructure/data/skill.js on lines 5..11

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 45.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Function getCourse has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                            getCourse(courseId) {
    // TODO This repo switch should not be here because we make a technical discrimination on the course id
    if (_.startsWith(courseId, 'rec')) {
      return courseRepository.get(courseId)
        .then((airtableCourse) => {
                          Severity: Minor
                          Found in api/lib/domain/services/course-service.js - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function verify has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                            verify(responseToken) {
    return new Promise((resolve, reject) => {
      request.post(`https://www.google.com/recaptcha/api/siteverify?secret=${config.googleReCaptcha.secret}&response=${responseToken}`, (err, response) => {
        if(err) {
          logger.error(err);
                          Severity: Minor
                          Found in api/lib/infrastructure/validators/grecaptcha-validator.js - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function adapt has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                            static adapt(answerStatus) {
    const UNIMPLEMENTED = 'unimplemented';
    const TIMEDOUT = 'timedout';
    const PARTIALLY = 'partially';
    const SKIPPED = 'aband';
                          Severity: Minor
                          Found in api/lib/interfaces/storage/database/AnswerStatusDatabaseAdapter.js - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function adapt has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                            static adapt(answerStatus) {
    const UNIMPLEMENTED = 'unimplemented';
    const TIMEDOUT = 'timedout';
    const PARTIALLY = 'partially';
    const SKIPPED = 'aband';
                          Severity: Minor
                          Found in api/lib/interfaces/serializer/json-api/AnswerStatusJsonApiAdapter.js - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          TODO found
                          Open

                              // TODO: remonter l'appel de l'adaptation dans le controlleur
                          Severity: Minor
                          Found in api/lib/domain/services/solution-service.js by fixme

                          TODO found
                          Open

                            // TODO return domain object
                          Severity: Minor
                          Found in api/lib/infrastructure/repositories/answer-repository.js by fixme
                          Severity
                          Category
                          Status
                          Source
                          Language