Sign upLogin

sh19910711/git-contest

View on GitHub
Star

Showing 77 of 77 total issues

Method run has 93 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def run

        # check options
        sub_commands = $sites.keys
Severity: Major
Found in lib/git/contest/command_line/sub_commands/submit_command.rb - About 3 hrs to fix

    Method run has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

          def run

        # check options
        sub_commands = $sites.keys
    Severity: Minor
    Found in lib/git/contest/command_line/sub_commands/submit_command.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method submit_ext has 55 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def submit_ext()
        # start
        trigger 'start'
        contest_id = @options[:contest_id]
        problem_id = @options[:problem_id]
    Severity: Major
    Found in lib/contest/driver/codeforces_driver.rb - About 2 hrs to fix

      Method submit_ext has 48 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def submit_ext
        trigger 'start'
        problem_id = @options[:problem_id]

        if (@options[:contest_id])
      Severity: Minor
      Found in lib/contest/driver/kattis_driver.rb - About 1 hr to fix

        Method run has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

              def run
        expand_contest_branch
        Git.require_branch $BRANCH

        Git.require_clean_working_tree
        Severity: Minor
        Found in lib/git/contest/command_line/sub_commands/finish_command.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method normalize_language has 44 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              def self.normalize_language label
        case label
        when "c", "C"
          return "clang"
        when "cpp", "C++", "c++", "cc", "cxx"
        Severity: Minor
        Found in lib/contest/driver/common.rb - About 1 hr to fix

          Method run has 44 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                def run
        expand_contest_branch
        Git.require_branch $BRANCH

        Git.require_clean_working_tree
          Severity: Minor
          Found in lib/git/contest/command_line/sub_commands/finish_command.rb - About 1 hr to fix

            Method resolve_language has 38 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                  def resolve_language(label)
        case label
        when "clang"
          return "10"
        when "cpp"
            Severity: Minor
            Found in lib/contest/driver/codeforces_driver.rb - About 1 hr to fix

              Method run_get has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
              Open

                    def run_get
        if tokens.length == 1
          # read key
          config = get_config
          cur = config
              Severity: Minor
              Found in lib/git/contest/command_line/sub_commands/config_command.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method submit_ext has 30 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                    def submit_ext
        trigger 'start'
        problem_id = @options[:problem_id]

        # submit
              Severity: Minor
              Found in lib/contest/driver/uva_online_judge_driver.rb - About 1 hr to fix

                Method run has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                      def run
        if Git.contest_is_initialized && ! options[:force]
          puts "Already initialized for git-contest."
          puts "To force reinitialization, use: git contest init -f"
          exit 0
                Severity: Minor
                Found in lib/git/contest/command_line/sub_commands/init_command.rb - About 1 hr to fix

                  Method run has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                        def run
        p options

        unless has_next_token?
          puts "Missing argument <name>"
                  Severity: Minor
                  Found in lib/git/contest/command_line/sub_commands/start_command.rb - About 1 hr to fix

                    Method resolve_language has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                          def resolve_language(label)
        case label
        when 'cpp'
          return '1'
        when 'c'
                    Severity: Minor
                    Found in lib/contest/driver/kattis_driver.rb - About 1 hr to fix

                      Method compare_branches has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                      Open

                        def self.compare_branches first, second
    commit1 = Git.do "rev-parse \"#{first}\""
    commit2 = Git.do "rev-parse \"#{second}\""
    if commit1 != commit2
      if Git.do_no_echo("merge-base \"#{commit1}\" \"#{commit2}\"")
                      Severity: Minor
                      Found in lib/git/contest/git.rb - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method submit_ext has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                      Open

                            def submit_ext()
        # start
        trigger 'start'
        contest_id = @options[:contest_id]
        problem_id = @options[:problem_id]
                      Severity: Minor
                      Found in lib/contest/driver/codeforces_driver.rb - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method submit_ext has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                            def submit_ext
        # start
        trigger 'start'
        problem_id = normalize_problem_id(@options[:problem_id])
                      Severity: Minor
                      Found in lib/contest/driver/aizu_online_judge_driver.rb - About 1 hr to fix

                        Method get_opts has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                              def get_opts
        get_opts_ext()
        define_options do
          opt(
            :source,
                        Severity: Minor
                        Found in lib/contest/driver/base.rb - About 1 hr to fix

                          Method resolve_language has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                                def resolve_language(label)
        case label
        when "clang"
          return "C"
        when "cpp"
                          Severity: Minor
                          Found in lib/contest/driver/aizu_online_judge_driver.rb - About 1 hr to fix

                            Method run has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                            Open

                                  def run
        if Git.contest_is_initialized && ! options[:force]
          puts "Already initialized for git-contest."
          puts "To force reinitialization, use: git contest init -f"
          exit 0
                            Severity: Minor
                            Found in lib/git/contest/command_line/sub_commands/init_command.rb - About 55 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Identical blocks of code found in 2 locations. Consider refactoring.
                            Open

                                def self.usage
      puts "usage: git contest <subcommand>"
      puts ""
      puts "Available subcommands are:"
      puts "  %-12s Initialize a new git repo." % ["init"]
                            Severity: Minor
                            Found in lib/git/contest/command_line/main_command.rb and 1 other location - About 50 mins to fix
                            lib/git/contest/command_line/sub_commands.rb on lines 19..30

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 43.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Severity
                            Category
                            Status
                            Source
                            Language