Sign upLogin

shanekrusen/coligny

View on GitHub
Star
lib/coligny.rb

Summary

Maintainability
C
1 day
Test Coverage

File coligny.rb has 347 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require "coligny/version"
require "preprocess"

module Coligny
  require 'date'
Severity: Minor
Found in lib/coligny.rb - About 4 hrs to fix

    Class ColignyYear has 30 methods (exceeds 20 allowed). Consider refactoring.
    Open

      class ColignyYear
    attr_accessor :months
    attr_reader :is_early
    
    #When an instance of ColignyYear is created, the year number MUST be specified,
    Severity: Minor
    Found in lib/coligny.rb - About 3 hrs to fix

      Method populate_saturn_equos has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def populate_saturn_equos
      if @is_early
        if (year_difference % 5 == 1) || (year_difference % 5 == 0) 
          @months.insert(8, ColignyMonth.new("Equos", 30))
        else
      Severity: Minor
      Found in lib/coligny.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method identify_year_locator has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def identify_year_locator(difference, years_between_instances)
      if @is_early
        if ((year_difference) % difference >= years_between_instances) || ((year_difference) % difference == 0)
          return true
        else
      Severity: Minor
      Found in lib/coligny.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method year_difference has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def year_difference
      if @is_metonic
        if @is_early
          return 4999 - @year     
        else
      Severity: Minor
      Found in lib/coligny.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method is_early? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def is_early?
      if @is_metonic
        if (@year < 4999)
          @is_early = true 
        else
      Severity: Minor
      Found in lib/coligny.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            elsif (year_difference % 5 == 0) || (year_difference % 5 == 4)
        @months.insert(8, ColignyMonth.new("Equos", 30))
      else
        @months.insert(8, ColignyMonth.new("Equos", 29))
      Severity: Minor
      Found in lib/coligny.rb and 1 other location - About 15 mins to fix
      lib/coligny.rb on lines 96..100

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 26.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if (year_difference % 5 == 1) || (year_difference % 5 == 0) 
          @months.insert(8, ColignyMonth.new("Equos", 30))
        else
          @months.insert(8, ColignyMonth.new("Equos", 29))
        end
      Severity: Minor
      Found in lib/coligny.rb and 1 other location - About 15 mins to fix
      lib/coligny.rb on lines 101..104

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 26.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status