Sign upLogin

shapeable/prototype-web

View on GitHub
Star

Showing 939 of 939 total issues

Class has too many lines. [101/100]
Open

    class UsersController < Api::BaseController
        include JsonResponses
        skip_before_filter :verify_authenticity_token  
        swagger_controller :users, "User Management", resource_path: "/api/users"
Severity: Minor
Found in web-app/app/controllers/api/v1/users_controller.rb by rubocop

This cop checks if the length a class exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for create is too high. [30.48/15]
Open

        def create
            if params[:user]
                user = User.new(users_params)
                if user.save
                    if params['alarm']
Severity: Minor
Found in web-app/app/controllers/api/v1/users_controller.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Assignment Branch Condition size for create is too high. [30.07/15]
Open

        def create
            if params[:message]
                unless Alarm.find_by(name: params[:message][:type]).nil?
                    ApiGeneralHazards.perform_async(params[:message][:type], params[:message][:description])
                    respond_to do |format|
Severity: Minor
Found in web-app/app/controllers/api/v1/messages_controller.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method has too many lines. [22/10]
Open

        def create
            if params[:user]
                user = User.new(users_params)
                if user.save
                    if params['alarm']
Severity: Minor
Found in web-app/app/controllers/api/v1/users_controller.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Function show has 68 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        show: function() {
            var title = this.getTitle();
            if (title && this.enabled) {
                var $tip = this.tip();
Severity: Major
Found in web-app/public/jquery.tipsy.js - About 2 hrs to fix

    Method has too many lines. [19/10]
    Open

      def parse_json_value(json_value, value, type)
    if !json_value['features'].nil? && json_value['features'].count > 0
        json_value['features'].each do |feature|
            if type == "weather"
                end_date = feature['attributes']['end_date']
    Severity: Minor
    Found in web-app/app/workers/api_weather_hazards.rb by rubocop

    This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

    Assignment Branch Condition size for send_message is too high. [24.35/15]
    Open

      def send_message(value)
    UserAlarm.all.each do |user_alarm|
        if (user_alarm.alarm_id.to_s == Alarm.find_by(name: value).id.to_s) && Message.find_by_user_id_and_alarm_id(user_alarm.user_id, user_alarm.alarm_id).nil?
            user = User.find(user_alarm.user_id)
            if user.email_actived
    Severity: Minor
    Found in web-app/app/workers/api_weather_hazards.rb by rubocop

    This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

    Assignment Branch Condition size for parse_json_value is too high. [23.43/15]
    Open

      def parse_json_value(json_value, value, type)
    if !json_value['features'].nil? && json_value['features'].count > 0
        json_value['features'].each do |feature|
            if type == "weather"
                end_date = feature['attributes']['end_date']
    Severity: Minor
    Found in web-app/app/workers/api_weather_hazards.rb by rubocop

    This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

    Method create has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

            def create
            if params[:user]
                user = User.new(users_params)
                if user.save
                    if params['alarm']
    Severity: Minor
    Found in web-app/app/controllers/api/v1/users_controller.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method has too many lines. [16/10]
    Open

            def create
            if params[:message]
                unless Alarm.find_by(name: params[:message][:type]).nil?
                    ApiGeneralHazards.perform_async(params[:message][:type], params[:message][:description])
                    respond_to do |format|
    Severity: Minor
    Found in web-app/app/controllers/api/v1/messages_controller.rb by rubocop

    This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

    Method has too many lines. [16/10]
    Open

      def perform(alert_id, message)
    begin
        UserAlarm.all.each do |user_alert|
            if user_alert.alarm_id.to_s == alert_id.to_s
                user = User.find(user_alert.user_id)
    Severity: Minor
    Found in web-app/app/workers/api_general_hazards.rb by rubocop

    This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        $.fn.tipsy.autoNS = function() {
        return $(this).offset().top > ($(document).scrollTop() + $(window).height() / 2) ? 's' : 'n';
    };
    Severity: Major
    Found in web-app/public/jquery.tipsy.js and 1 other location - About 2 hrs to fix
    web-app/public/jquery.tipsy.js on lines 301..303

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 81.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        $.fn.tipsy.autoWE = function() {
        return $(this).offset().left > ($(document).scrollLeft() + $(window).width() / 2) ? 'e' : 'w';
    };
    Severity: Major
    Found in web-app/public/jquery.tipsy.js and 1 other location - About 2 hrs to fix
    web-app/public/jquery.tipsy.js on lines 297..299

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 81.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    File jquery.tipsy.js has 260 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    // tipsy, facebook style tooltips for jquery
// version 1.0.0a
// (c) 2008-2010 jason frame [jason@onehackoranother.com]
// released under the MIT license
    Severity: Minor
    Found in web-app/public/jquery.tipsy.js - About 2 hrs to fix

      Function tipsy has 55 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          $.fn.tipsy = function(options) {

        if (options === true) {
            return this.data('tipsy');
        } else if (typeof options == 'string') {
      Severity: Major
      Found in web-app/public/jquery.tipsy.js - About 2 hrs to fix

        Block has too many lines. [47/25]
        Open

        Rails.application.routes.draw do
  scope "(:locale)", :locale => /en|es/ do
    root 'pages#landing'
    resources :users
    resources :pages do
        Severity: Minor
        Found in web-app/config/routes.rb by rubocop

        This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

        Method has too many lines. [14/10]
        Open

          def get_json_from_type(name, type)
    if type == "weather"
        json = "https://idpgis.ncep.noaa.gov/arcgis/rest/services/NWS_Climate_Outlooks/cpc_weather_hazards/MapServer/1/query?"+
        "where=&text=#{name.to_param}+&objectIds=&time=&geometry=&geometryType=esriGeometryEnvelope&inSR="+
        "&spatialRel=esriSpatialRelIntersects&relationParam=&outFields=start_date%2C+end_date&returnGeometry=true"+
        Severity: Minor
        Found in web-app/app/workers/api_weather_hazards.rb by rubocop

        This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

        Block has too many lines. [46/25]
        Open

        ActiveRecord::Schema.define(version: 20170303094158) do

  # These are extensions that must be enabled in order to support this database
  enable_extension "plpgsql"
        Severity: Minor
        Found in web-app/db/schema.rb by rubocop

        This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

        Method has too many lines. [12/10]
        Open

          def alert_class_for(flash_type)
      case flash_type.to_sym
      when :success
        "flash-success"
      when :error
        Severity: Minor
        Found in web-app/app/helpers/application_helper.rb by rubocop

        This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

        Method has too many lines. [12/10]
        Open

            def get_user(user)
     return {id: user.id,
            email: user.email,
            phone_number:  user.phone_number,
            gender: user.gender,
        Severity: Minor
        Found in web-app/app/controllers/api/v1/users_controller.rb by rubocop

        This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

        Severity
        Category
        Status
        Source
        Language