Sign upLogin

sharetribe/sharetribe

View on GitHub
Star
app/mailers/transaction_mailer.rb

Summary

Maintainability
D
1 day
Test Coverage

Method payment_receipt_to_seller has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

  def payment_receipt_to_seller(transaction, seller_model = nil, buyer_model = nil, community = nil)
    seller_model ||= Person.find(transaction.listing_author_id)
    buyer_model ||= Person.find(transaction.starter_id)
    @community = community || Community.find(transaction.community_id)
Severity: Minor
Found in app/mailers/transaction_mailer.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File transaction_mailer.rb has 264 lines of code (exceeds 250 allowed). Consider refactoring.
Open

include ApplicationHelper
include ListingsHelper
# rubocop:enable Style/MixinUsage

class TransactionMailer < ActionMailer::Base
Severity: Minor
Found in app/mailers/transaction_mailer.rb - About 2 hrs to fix

    Method payment_receipt_to_seller has 53 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def payment_receipt_to_seller(transaction, seller_model = nil, buyer_model = nil, community = nil)
    seller_model ||= Person.find(transaction.listing_author_id)
    buyer_model ||= Person.find(transaction.starter_id)
    @community = community || Community.find(transaction.community_id)
    Severity: Major
    Found in app/mailers/transaction_mailer.rb - About 2 hrs to fix

      Method payment_receipt_to_buyer has 45 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def payment_receipt_to_buyer(transaction, seller_model = nil, buyer_model = nil, community = nil)
    seller_model ||= Person.find(transaction.listing_author_id)
    buyer_model ||= Person.find(transaction.starter_id)
    @community = community || Community.find(transaction.community_id)
    payment = TransactionService::Transaction.payment_details(transaction)
      Severity: Minor
      Found in app/mailers/transaction_mailer.rb - About 1 hr to fix

        Method payment_receipt_to_buyer has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

          def payment_receipt_to_buyer(transaction, seller_model = nil, buyer_model = nil, community = nil)
    seller_model ||= Person.find(transaction.listing_author_id)
    buyer_model ||= Person.find(transaction.starter_id)
    @community = community || Community.find(transaction.community_id)
    payment = TransactionService::Transaction.payment_details(transaction)
        Severity: Minor
        Found in app/mailers/transaction_mailer.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method transaction_preauthorized has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def transaction_preauthorized(transaction)
    @transaction = transaction
    @community = transaction.community

    recipient = transaction.author
        Severity: Minor
        Found in app/mailers/transaction_mailer.rb - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            def transaction_cancellation_dismissed(transaction, recipient)
    @transaction = transaction
    @is_seller = transaction.author == recipient
    community = transaction.community
    set_up_layout_variables(recipient, community)
          Severity: Major
          Found in app/mailers/transaction_mailer.rb and 1 other location - About 1 hr to fix
          app/mailers/transaction_mailer.rb on lines 230..242

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 69.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            def transaction_refunded(transaction, recipient)
    @transaction = transaction
    @is_seller = transaction.author == recipient
    community = transaction.community
    set_up_layout_variables(recipient, community)
          Severity: Major
          Found in app/mailers/transaction_mailer.rb and 1 other location - About 1 hr to fix
          app/mailers/transaction_mailer.rb on lines 248..260

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 69.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                mail(to: recipient.confirmed_notification_emails_to,
           from: community_specific_sender(community),
           subject: t("emails.transaction_commission_charge_failed.subject")) do |format|
             format.html { render v2_template(community.id, 'transaction_commission_charge_failed'), layout: v2_layout(community.id) }
          Severity: Minor
          Found in app/mailers/transaction_mailer.rb and 3 other locations - About 15 mins to fix
          app/mailers/person_mailer.rb on lines 137..142
          app/mailers/person_mailer.rb on lines 156..159
          app/mailers/person_mailer.rb on lines 215..218

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 26.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status