Sign upLogin

sharetribe/sharetribe

View on GitHub
Star
app/models/listing.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Class Listing has 29 methods (exceeds 20 allowed). Consider refactoring.
Open

class Listing < ApplicationRecord

  include ApplicationHelper
  include ActionView::Helpers::TranslationHelper
  include Rails.application.routes.url_helpers
Severity: Minor
Found in app/models/listing.rb - About 3 hrs to fix

    File listing.rb has 254 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class Listing < ApplicationRecord

  include ApplicationHelper
  include ActionView::Helpers::TranslationHelper
  include Rails.application.routes.url_helpers
    Severity: Minor
    Found in app/models/listing.rb - About 2 hrs to fix

      Method custom_field_value_factory has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def custom_field_value_factory(custom_field_id, answer_value)
    question = CustomField.find(custom_field_id)

    answer = question.with_type do |question_type|
      case question_type
      Severity: Minor
      Found in app/models/listing.rb - About 1 hr to fix

        Method notify_followers has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          def notify_followers(community, current_user, update)
    return unless community.listing_comments_in_use

    followers.each do |follower|
      unless follower.id == current_user.id
        Severity: Minor
        Found in app/models/listing.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status