Sign upLogin

sharetribe/sharetribe

View on GitHub
Star
app/models/person.rb

Summary

Maintainability
D
2 days
Test Coverage

Class Person has 59 methods (exceeds 20 allowed). Consider refactoring.
Open

class Person < ApplicationRecord

  include ErrorsHelper
  include ApplicationHelper
  include DeletePerson
Severity: Major
Found in app/models/person.rb - About 1 day to fix

    File person.rb has 421 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'json'
require 'rest_client'
require "open-uri"

# This class represents a person (a user of Sharetribe).
    Severity: Minor
    Found in app/models/person.rb - About 6 hrs to fix

      Method custom_update has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        def custom_update(params)
    if params[:preferences]
      update(params)
    else
      Severity: Minor
      Found in app/models/person.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method update_follow_status has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def update_follow_status(listing, status)
    unless id == listing.author.id
      if status
        follow(listing) unless is_following?(listing)
      else
      Severity: Minor
      Found in app/models/person.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status