Sign upLogin

sharetribe/sharetribe

View on GitHub
Star
app/presenters/concerns/listing_availability_manage.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method availability_per_hour_calculate_blocked_dates has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

  def availability_per_hour_calculate_blocked_dates
    return @availability_per_hour_raw_blocked_dates if defined?(@availability_per_hour_raw_blocked_dates)

    all_options = availability_per_hour_calculate_options_for_select
    result = []
Severity: Minor
Found in app/presenters/concerns/listing_availability_manage.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method availability_per_hour_calculate_options_for_select has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

  def availability_per_hour_calculate_options_for_select
    return @availability_per_hour_raw_options_for_select if defined?(@availability_per_hour_raw_options_for_select)

    result = {}
    current_day = nil
Severity: Minor
Found in app/presenters/concerns/listing_availability_manage.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method availability_per_hour_calculate_options_for_select has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def availability_per_hour_calculate_options_for_select
    return @availability_per_hour_raw_options_for_select if defined?(@availability_per_hour_raw_options_for_select)

    result = {}
    current_day = nil
Severity: Minor
Found in app/presenters/concerns/listing_availability_manage.rb - About 1 hr to fix

    Method availability_per_hour_calculate_blocked_dates has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def availability_per_hour_calculate_blocked_dates
    return @availability_per_hour_raw_blocked_dates if defined?(@availability_per_hour_raw_blocked_dates)

    all_options = availability_per_hour_calculate_options_for_select
    result = []
    Severity: Minor
    Found in app/presenters/concerns/listing_availability_manage.rb - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status