Sign upLogin

sharetribe/sharetribe

View on GitHub
Star
app/presenters/person/payment_settings_presenter.rb

Summary

Maintainability
D
2 days
Test Coverage

Class PaymentSettingsPresenter has 63 methods (exceeds 20 allowed). Consider refactoring.
Open

class Person::PaymentSettingsPresenter
  include Person::PaymentSettingsCommon

  private
Severity: Major
Found in app/presenters/person/payment_settings_presenter.rb - About 1 day to fix

    File payment_settings_presenter.rb has 309 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class Person::PaymentSettingsPresenter
  include Person::PaymentSettingsCommon

  private
    Severity: Minor
    Found in app/presenters/person/payment_settings_presenter.rb - About 3 hrs to fix

      Method parsed_seller_account has 50 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def parsed_seller_account
    bank_record = api_seller_account.external_accounts.select{|x| x["default_for_currency"] }.first || {}
    bank_number = if bank_record.present?
      [bank_record["country"], bank_record["bank_name"], bank_record["currency"], "****#{bank_record['last4']}"].join(", ").upcase
    end
      Severity: Minor
      Found in app/presenters/person/payment_settings_presenter.rb - About 2 hrs to fix

        Method stripe_account_verification has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

          def stripe_account_verification
    return @stripe_account_verification if defined?(@stripe_account_verification)

    requirements = api_seller_account.requirements
    @stripe_account_verification =
        Severity: Minor
        Found in app/presenters/person/payment_settings_presenter.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method parsed_seller_account has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

          def parsed_seller_account
    bank_record = api_seller_account.external_accounts.select{|x| x["default_for_currency"] }.first || {}
    bank_number = if bank_record.present?
      [bank_record["country"], bank_record["bank_name"], bank_record["currency"], "****#{bank_record['last4']}"].join(", ").upcase
    end
        Severity: Minor
        Found in app/presenters/person/payment_settings_presenter.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          def stripe_tx_settings
    Maybe(settings_api.get(community_id: community.id, payment_gateway: :stripe, payment_process: :preauthorize))
    .select { |result| result[:success] }
    .map { |result| result[:data] }
    .or_else({})
        Severity: Minor
        Found in app/presenters/person/payment_settings_presenter.rb and 1 other location - About 20 mins to fix
        app/presenters/person/payment_settings_presenter.rb on lines 342..346

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 27.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          def paypal_tx_settings
    Maybe(settings_api.get(community_id: community.id, payment_gateway: :paypal, payment_process: :preauthorize))
    .select { |result| result[:success] }
    .map { |result| result[:data] }
    .or_else({})
        Severity: Minor
        Found in app/presenters/person/payment_settings_presenter.rb and 1 other location - About 20 mins to fix
        app/presenters/person/payment_settings_presenter.rb on lines 349..353

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 27.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status